Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore @babel/register compat with @babel/core@7.5.x #14136

Merged
merged 1 commit into from Jan 11, 2022
Merged

Restore @babel/register compat with @babel/core@7.5.x #14136

merged 1 commit into from Jan 11, 2022

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jan 11, 2022 •
edited

Q                       A
Fixed Issues? Fixes #14131
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

loadOptionsSync is not available in every Babel 7 version.

EDIT: This PR is broken, fixed by #14137.

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories i: regression labels Jan 11, 2022
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50690/

@JLHwung
Copy link
Contributor

JLHwung commented Jan 11, 2022

I am wondering why the bug is not caught by https://github.com/babel/babel/blob/main/scripts/integration-tests/e2e-babel-old-version.sh

@nicolo-ribaudo
Copy link
Member Author

@JLHwung Because in that test we use old @babel/core to compile Babel, but it doesn't use @babel/register to do so.

@nicolo-ribaudo nicolo-ribaudo merged commit db08d94 into babel:main Jan 11, 2022
@nicolo-ribaudo nicolo-ribaudo deleted the fix-14131 branch January 11, 2022 22:26
@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Jan 11, 2022 •
edited

(releasing as soon as CI passes on main)

@nicolo-ribaudo
Copy link
Member Author

I didn't notice CI was failing here 😬

nicolo-ribaudo added a commit to nicolo-ribaudo/babel that referenced this pull request Jan 11, 2022
@nicolo-ribaudo
Follow up to babel#14136
e4620d6
nicolo-ribaudo added a commit that referenced this pull request Jan 11, 2022
@nicolo-ribaudo
Follow up to #14136 (#14137)
928f06c
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
4 participants
@nicolo-ribaudo @babel-bot @JLHwung @existentialism