fix: handle tokens for invalid template element #14055
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced at #13919. We skip evaluating the template value when a template element is invalid, i.e. it may contain invalid Unicode escape or octal escape.
Since Babel parser updates have broken prettier for several times (https://github.com/babel/babel/issues?q=is%3Aissue+label%3A%22i%3A+regression%22+prettier+label%3A%22pkg%3A+parser%22), I plan to add prettier-e2e test in another PR so hopefully a babel parser patch release will not break prettier in the future.