Implement parser support for destructuring-private #13999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: New Feature 🚀
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51000/ |
JLHwung
force-pushed
the
feat-7.17.0/destructuring-private
branch
from
c87850c
to
05317f7
Compare
|
I chatted with @JLHwung on Slack; since the transform plugin is not ready yet we can merge the parser support in 7.17.0 and defer the transform to a future minor. |
JLHwung
force-pushed
the
feat-7.17.0/destructuring-private
branch
from
05317f7
to
d8c7a8a
Compare
JLHwung
changed the title
* feat: parse destructuring private * add test cases * fix: register private name on destructuring * add typings * add syntax plugin * add generator test case * add syntax plugin to preset-stage-2 * fix flow errors * address review comments * fix: use private name in toAssignable * test: add case with undefined refExpressionErrors
JLHwung
force-pushed
the
feat-7.17.0/destructuring-private
branch
from
d8c7a8a
to
269f49c
Compare
DamienScrappie8239
approved these changes
Feb 1, 2022
JLHwung
force-pushed
the
feat-7.17.0/destructuring-private
branch
from
f3f658a
to
38ef0ab
Compare
nicolo-ribaudo
added
the
PR: Ready to be Merged
nicolo-ribaudo
removed
the
PR: New Feature 🚀
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tracks parser support progress for https://github.com/tc39/proposal-destructuring-private.
Related #13889