Support transforming params of arrow functions in class fields #13941
Conversation
nicolo-ribaudo
commented
Nov 8, 2021
•
nicolo-ribaudo
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #13939 |
| Patch: Bug Fix? | Yes |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
nicolo-ribaudo
added
PR: Bug Fix 🐛
| @@ -0,0 +1,7 @@ | |||
| var _this = this; | |||
There was a problem hiding this comment.
This is another bug fixed by the new if (!path.isFunction()) return; check in the plugin.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49716/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 59c8ff9:
|
|
|
||
| // In some cases arrowFunctionToExpression replaces the function with a wrapper. | ||
| // Return early; the wrapped function will be visited later in the AST traversal. | ||
| if (!path.isFunction()) return; |
There was a problem hiding this comment.
Q: Can this check be strengthen to path.isFunctionExpression()?
There was a problem hiding this comment.
Yes, currently path is guaranteed to be either a FunctionExpression or a CallExpression
| // TODO(Babel 8): Consider defaulting to `false` for spec compliancy | ||
| noNewArrows = true, | ||
| allowInsertArrow = true, | ||
| ) { | ||
| const thisEnvFn = fnPath.findParent(p => { | ||
| ): { thisBinding: string; fnPath: NodePath<t.Function> } { |
There was a problem hiding this comment.
Can you add some comments about the return type? Especially we may have different fnPath output than the input.
| ); | ||
| }); | ||
| const inConstructor = thisEnvFn?.node.kind === "constructor"; | ||
| const inConstructor = thisEnvFn.isClassMethod({ kind: "constructor" }); | ||
|
|
||
| if (thisEnvFn.isClassProperty()) { |
There was a problem hiding this comment.
| if (thisEnvFn.isClassProperty()) { | |
| if (thisEnvFn.isClassProperty() || thisEnvFn.isClassPrivateProperty()) { |
github-actions
bot
added
the
outdated
