Use full import specifier path in tests #13938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49741/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9a07e1a:
|
|
I missed some of them |
nicolo-ribaudo
force-pushed
the
test-explicit-js-ext
branch
from
105eb94
to
9a07e1a
Compare
4 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I'm moving this discussion to #13966. |
JLHwung
approved these changes
Nov 22, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the main blocker for migrating to ESM (#13414) is Jest support (Jest reimplements the whole ESM linker, and it has some bugs + Node.js doesn't have a stable API to do it), I'm experimenting with a lightweight approach where I only use part of Jest and run the tests in a native Node.js environment.
I'm starting by only running the tests as ESM (rather than converting them to CJS on-the-fly), but in order to run them natively
importstatements must have the full path.