New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse destructuring private fields #13931
Merged
JLHwung
merged 11 commits into
babel:feat-7.17.0/destructuring-private
from
JLHwung:parse-destructuring-private
Nov 25, 2021
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
431c722
feat: parse destructuring private
JLHwung e6aa04f
add test cases
JLHwung 67908c9
fix: register private name on destructuring
JLHwung be4386a
add typings
JLHwung 6fdaccb
add syntax plugin
JLHwung fbe9b1c
add generator test case
JLHwung 3f03eee
add syntax plugin to preset-stage-2
JLHwung 055f74f
fix flow errors
JLHwung 8d0ac28
address review comments
JLHwung 7ce9408
fix: use private name in toAssignable
JLHwung 370efa6
test: add case with undefined refExpressionErrors
JLHwung File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
packages/babel-generator/test/fixtures/types/PrivateName/input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
class C { | ||
#x; | ||
m() { | ||
#x in (#x in this); | ||
var { #x: x } = this; | ||
} | ||
} |
3 changes: 3 additions & 0 deletions
3
packages/babel-generator/test/fixtures/types/PrivateName/options.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"plugins": ["destructuringPrivate"] | ||
} |
11 changes: 11 additions & 0 deletions
11
packages/babel-generator/test/fixtures/types/PrivateName/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
class C { | ||
#x; | ||
|
||
m() { | ||
#x in (#x in this); | ||
var { | ||
#x: x | ||
} = this; | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
...fixtures/es2022/class-private-properties/invalid-object-property-with-assignment/input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
(class { | ||
#x; | ||
m = { | ||
#x: x, | ||
y: y = m | ||
} | ||
}) |
115 changes: 115 additions & 0 deletions
115
...tures/es2022/class-private-properties/invalid-object-property-with-assignment/output.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,115 @@ | ||
{ | ||
"type": "File", | ||
"start":0,"end":53,"loc":{"start":{"line":1,"column":0},"end":{"line":7,"column":2}}, | ||
"errors": [ | ||
"SyntaxError: Unexpected private name. (4:4)" | ||
], | ||
"program": { | ||
"type": "Program", | ||
"start":0,"end":53,"loc":{"start":{"line":1,"column":0},"end":{"line":7,"column":2}}, | ||
"sourceType": "script", | ||
"interpreter": null, | ||
"body": [ | ||
{ | ||
"type": "ExpressionStatement", | ||
"start":0,"end":53,"loc":{"start":{"line":1,"column":0},"end":{"line":7,"column":2}}, | ||
"expression": { | ||
"type": "ClassExpression", | ||
"start":1,"end":52,"loc":{"start":{"line":1,"column":1},"end":{"line":7,"column":1}}, | ||
"id": null, | ||
"superClass": null, | ||
"body": { | ||
"type": "ClassBody", | ||
"start":7,"end":52,"loc":{"start":{"line":1,"column":7},"end":{"line":7,"column":1}}, | ||
"body": [ | ||
{ | ||
"type": "ClassPrivateProperty", | ||
"start":11,"end":14,"loc":{"start":{"line":2,"column":2},"end":{"line":2,"column":5}}, | ||
"static": false, | ||
"key": { | ||
"type": "PrivateName", | ||
"start":11,"end":13,"loc":{"start":{"line":2,"column":2},"end":{"line":2,"column":4}}, | ||
"id": { | ||
"type": "Identifier", | ||
"start":12,"end":13,"loc":{"start":{"line":2,"column":3},"end":{"line":2,"column":4},"identifierName":"x"}, | ||
"name": "x" | ||
} | ||
}, | ||
"value": null | ||
}, | ||
{ | ||
"type": "ClassProperty", | ||
"start":17,"end":50,"loc":{"start":{"line":3,"column":2},"end":{"line":6,"column":3}}, | ||
"static": false, | ||
"key": { | ||
"type": "Identifier", | ||
"start":17,"end":18,"loc":{"start":{"line":3,"column":2},"end":{"line":3,"column":3},"identifierName":"m"}, | ||
"name": "m" | ||
}, | ||
"computed": false, | ||
"value": { | ||
"type": "ObjectExpression", | ||
"start":21,"end":50,"loc":{"start":{"line":3,"column":6},"end":{"line":6,"column":3}}, | ||
"properties": [ | ||
{ | ||
"type": "ObjectProperty", | ||
"start":27,"end":32,"loc":{"start":{"line":4,"column":4},"end":{"line":4,"column":9}}, | ||
"method": false, | ||
"key": { | ||
"type": "PrivateName", | ||
"start":27,"end":29,"loc":{"start":{"line":4,"column":4},"end":{"line":4,"column":6}}, | ||
"id": { | ||
"type": "Identifier", | ||
"start":28,"end":29,"loc":{"start":{"line":4,"column":5},"end":{"line":4,"column":6},"identifierName":"x"}, | ||
"name": "x" | ||
} | ||
}, | ||
"shorthand": false, | ||
"value": { | ||
"type": "Identifier", | ||
"start":31,"end":32,"loc":{"start":{"line":4,"column":8},"end":{"line":4,"column":9},"identifierName":"x"}, | ||
"name": "x" | ||
} | ||
}, | ||
{ | ||
"type": "ObjectProperty", | ||
"start":38,"end":46,"loc":{"start":{"line":5,"column":4},"end":{"line":5,"column":12}}, | ||
"method": false, | ||
"key": { | ||
"type": "Identifier", | ||
"start":38,"end":39,"loc":{"start":{"line":5,"column":4},"end":{"line":5,"column":5},"identifierName":"y"}, | ||
"name": "y" | ||
}, | ||
"computed": false, | ||
"shorthand": false, | ||
"value": { | ||
"type": "AssignmentExpression", | ||
"start":41,"end":46,"loc":{"start":{"line":5,"column":7},"end":{"line":5,"column":12}}, | ||
"operator": "=", | ||
"left": { | ||
"type": "Identifier", | ||
"start":41,"end":42,"loc":{"start":{"line":5,"column":7},"end":{"line":5,"column":8},"identifierName":"y"}, | ||
"name": "y" | ||
}, | ||
"right": { | ||
"type": "Identifier", | ||
"start":45,"end":46,"loc":{"start":{"line":5,"column":11},"end":{"line":5,"column":12},"identifierName":"m"}, | ||
"name": "m" | ||
} | ||
} | ||
} | ||
] | ||
} | ||
} | ||
] | ||
}, | ||
"extra": { | ||
"parenthesized": true, | ||
"parenStart": 0 | ||
} | ||
} | ||
} | ||
], | ||
"directives": [] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: