Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor bindingProperty parsing #13929

Merged
merged 8 commits into from Nov 12, 2021
Merged

Refactor bindingProperty parsing #13929

merged 8 commits into from Nov 12, 2021

Commits on Nov 4, 2021

  1. refactor: inline parseMaybePrivateName

    @JLHwung
    JLHwung committed Nov 4, 2021
    Copy the full SHA
    c97b408 View commit details
    Browse the repository at this point in the history

  2. correct test case

    @JLHwung
    JLHwung committed Nov 4, 2021
    Copy the full SHA
    d3a3206 View commit details
    Browse the repository at this point in the history

  3. perf: fast exit in checkExpressionErrors

    @JLHwung
    JLHwung committed Nov 4, 2021
    Copy the full SHA
    35f31db View commit details
    Browse the repository at this point in the history

  4. refactor: add parseBindingProperty

    @JLHwung
    JLHwung committed Nov 4, 2021
    Copy the full SHA
    5b815d5 View commit details
    Browse the repository at this point in the history

  5. fix: private property with variance

    @JLHwung
    JLHwung committed Nov 4, 2021
    Copy the full SHA
    5c6e481 View commit details
    Browse the repository at this point in the history

  6. Update packages/babel-parser/src/parser/expression.js 

    Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
    @JLHwung @nicolo-ribaudo
    JLHwung and nicolo-ribaudo committed Nov 4, 2021
    Copy the full SHA
    1e63592 View commit details
    Browse the repository at this point in the history

  7. chore: update testcase

    @JLHwung
    JLHwung committed Nov 4, 2021
    Copy the full SHA
    647ecd4 View commit details
    Browse the repository at this point in the history

  8. refactor: remove refExpressionErrors for record/tuple 

    They are always non-ambiguous.
    @JLHwung
    JLHwung committed Nov 4, 2021
    Copy the full SHA
    2efdbf8 View commit details
    Browse the repository at this point in the history