Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ts] Support private methods overloads #13876

Merged
merged 4 commits into from Oct 26, 2021

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Oct 23, 2021

Q                       A
Fixed Issues? Fixes #13875
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser area: typescript labels Oct 23, 2021
@babel-bot
Copy link
Collaborator

babel-bot commented Oct 23, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49364/

@@ -0,0 +1,7 @@
class Test {
Copy link
Contributor

@JLHwung JLHwung Oct 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS currently throws when class method is missing implementation. We can use declare class here.

And TS also throws for non-private overload.

class C {
  z(): string;
  z(): number;
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It reports the same error for function declarations:

function a(): number;

I think we can continue considering this a type-checker level error as we have been doing so far, since it doesn't affect the compiler output in any way.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 24, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8e81cf0:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo merged commit fb7ddf4 into babel:main Oct 26, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the ts-priv-method-overrides branch October 26, 2021 05:29
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TypeScript syntax error with overloaded private methods
4 participants