Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing inner comments in class expressions #13821

Merged
merged 1 commit into from Oct 6, 2021

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Oct 6, 2021

Fixes #13819.

Q                       A
Fixed Issues? Fixes #13819
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link n/a
Any Dependency Changes? No
License MIT

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 6, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bcd08d6:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

Copy link
Member

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fedeci fedeci added area: comments pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Oct 6, 2021
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit 58a65e9 into babel:main Oct 6, 2021
@overlookmotel overlookmotel deleted the class-inner-comments branch October 6, 2021 14:12
@JLHwung
Copy link
Contributor

JLHwung commented Oct 6, 2021

We may extend similar logic to other nodes, too:

To name a few:

class C {
  static /* 1 */ [a] = 1;
  * /* 2 */ [b]() {}
  async /* 3 */ [c]() {}
}
import "x" assert /* 4 */ { type: "json" }
async /* 5 */ (x) /* 6 */ => {}

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: comments outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: generate does not output innerComments on class expression
4 participants