Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect comments around parentheses in expressions #13803
Collect comments around parentheses in expressions #13803
Changes from 3 commits
ae97220
62ff104
0d1c954
7ba50d0
418cc3a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see there is 10% performance regression on the case
babel-parser/many-leading-trailing-comments
.The generated machine code of
setComments
is inlined in serveral functions, such asfinishNodeAt
andfinishNode
. Here is what it looks likeAs we can see, V8 did computes
${position}Comments
based on the input feedback. However, the fast property access is degraded to slow access (KeyedLoadIC_Megamorphic), which should be responsible for the performance regression here sincesetComments
is a hot path in the benchmark case.We can fix the regression here by copying
setLeadingComments
fromsetInnerComments
andsetTrailingComments
:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just to align the signature to the other two functions: since they are really similar it's easier to keep the implementation the same.