Update Jest to 27.2.0
#13776
Update Jest to 27.2.0
#13776
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b6e6671:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48824/ |
test/jestExportsMapResolver.cjs
Outdated
|
|
||
| const resolvers = new Map(); | ||
| function getResolver(conditionNames) { | ||
| const key = conditionNames.join(":::"); |
There was a problem hiding this comment.
Q: Is ":::" a hardcoded separator used by enhanced-resolve? Can we link to where it comes from?
Ah I see, it is only used in this resolver, maybe better name it actually.
There was a problem hiding this comment.
It's just to build a cache key, to avoid reinstantiating the resolver for every request. Should I rename the map to resolversCache?
There was a problem hiding this comment.
Either looks good to me, I would prefer name the ":::" actually, to signal that it is only used by us internally.
github-actions
bot
added
the
outdated
Jest 27.2.0 includes jestjs/jest#11859. It's better than the current resolution we had, because we always assumed that importer files where using
require(). This PR aligns better Jest's behavior with the native Node.js resolution.