Tokenize keywords-like identifier as new tokens #13769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6fdea76:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48823/ |
JLHwung
force-pushed
the
tokenize-keywords-like-identifier
branch
from
3bd0561
to
1ccd28b
Compare
JLHwung
added
pkg: parser
PR: Bug Fix 🐛
JLHwung
commented
Sep 17, 2021
JLHwung
commented
Sep 17, 2021
| lookahead.type === tt.string || | ||
| lookahead.type === tt.num | ||
| ) { | ||
| if (tokenIsLiteralPropertyName(lookahead.type)) { |
There was a problem hiding this comment.
This is a bug fix: Flow allows any identifiers to be the accessor type property. e.g.
type A = { get if(): number }is a valid Flow code.
JLHwung
commented
Sep 17, 2021
| this.match(tt.name) && | ||
| this.state.value === "interface" | ||
| ) { | ||
| if (this.state.strict && this.isContextual(tt._interface)) { |
There was a problem hiding this comment.
JLHwung
added
PR: Spec Compliance 👓
JLHwung
force-pushed
the
tokenize-keywords-like-identifier
branch
from
5a1ca81
to
6fdea76
Compare
|
Ugh this title is going to mean nothing when it appears in the changelog under "Spec Compliance" 😬 |
nicolo-ribaudo
approved these changes
Sep 21, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
interf\u{61}ce A {}whenflowsis enabled.This PR is based on #13768. The
tt.nameis now exploded into multiple tokens, each of them represents an "interested" identifier name (such asasync,static) which subjects to additional parsing logic. The tokens is not limited to ES, the Flow/TS keyword-likes are also tokenized differently for parsing convenience.The
isContextual,expectContextualnow accept a token type instead of a string since these names are tokenized into different types. The verification is simplified because, e.g.token === tt._asyncalready implies thattokenis an identifier token.