Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Duplicate function call in variable destructuring #13711

Merged
merged 17 commits into from Sep 7, 2021
Merged

fix: Duplicate function call in variable destructuring #13711

merged 17 commits into from Sep 7, 2021

Commits on Sep 2, 2021

  1. Add test case demonstrating invalid behavior

    @dan-kez
    dan-kez committed Sep 2, 2021
    Copy the full SHA
    51c520d View commit details
    Browse the repository at this point in the history

  2. Add conditional check for child properties so RHS is not duplicated

    @dan-kez
    dan-kez committed Sep 2, 2021
    Copy the full SHA
    b74dfb9 View commit details
    Browse the repository at this point in the history

  3. Add recursive check to find any nested non single-property case

    @dan-kez
    dan-kez committed Sep 2, 2021
    Copy the full SHA
    cb530b1 View commit details
    Browse the repository at this point in the history

  4. Add case for array destructuring

    @dan-kez
    dan-kez committed Sep 2, 2021
    Copy the full SHA
    698b776 View commit details
    Browse the repository at this point in the history

  5. Add test case for a nested rest element

    @dan-kez
    dan-kez committed Sep 2, 2021
    Copy the full SHA
    b1c393e View commit details
    Browse the repository at this point in the history

  6. More safely recurse through array destructuring

    @dan-kez
    dan-kez committed Sep 2, 2021
    Copy the full SHA
    87a02d1 View commit details
    Browse the repository at this point in the history

  7. Traverse assignment and nested rest operations

    @dan-kez
    dan-kez committed Sep 2, 2021
    Copy the full SHA
    84c2300 View commit details
    Browse the repository at this point in the history

  8. Refactor to be more clear which case statement we are executing against

    @dan-kez
    dan-kez committed Sep 2, 2021
    Copy the full SHA
    3c851b4 View commit details
    Browse the repository at this point in the history

  9. Update missed snapshots

    @dan-kez
    dan-kez committed Sep 2, 2021
    Copy the full SHA
    af17b56 View commit details
    Browse the repository at this point in the history

  10. Update packages/babel-plugin-proposal-object-rest-spread/src/index.js 

    Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
    @dan-kez @JLHwung
    dan-kez and JLHwung committed Sep 2, 2021
    Copy the full SHA
    8ace7f1 View commit details
    Browse the repository at this point in the history

  11. Filter null array elements, add early return, remove optional chaining

    @dan-kez
    dan-kez committed Sep 2, 2021
    Copy the full SHA
    ab3b603 View commit details
    Browse the repository at this point in the history

  12. Use stronger type assertions

    @dan-kez
    dan-kez committed Sep 2, 2021
    Copy the full SHA
    80fb872 View commit details
    Browse the repository at this point in the history

  13. Update fall through to be false; add early return to RestElement case

    @dan-kez
    dan-kez committed Sep 2, 2021
    Copy the full SHA
    60cabe8 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. Move hasMoreThanOneBinding to its own file with distinct tests

    @dan-kez
    dan-kez committed Sep 3, 2021
    Copy the full SHA
    df3d149 View commit details
    Browse the repository at this point in the history

  2. Rename testing helper to more appropriately match business logic

    @dan-kez
    dan-kez committed Sep 3, 2021
    Copy the full SHA
    80b1692 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. Merge branch 'babel:main' into duplicate_function_call_in_variable_de… 

    …structuring
    @dan-kez
    dan-kez committed Sep 7, 2021
    Copy the full SHA
    317065d View commit details
    Browse the repository at this point in the history

  2. Yarn Dedup & rename hasMoreThanOneBinding to shouldStoreRHSInTemporar… 

    …yVariable
    @dan-kez
    dan-kez committed Sep 7, 2021
    Copy the full SHA
    4be2624 View commit details
    Browse the repository at this point in the history