Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ts): raise error for export default interface {} #13622

Merged
merged 1 commit into from Aug 2, 2021
Merged

fix(ts): raise error for export default interface {} #13622

merged 1 commit into from Aug 2, 2021

Conversation

a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented Jul 31, 2021 •
edited by JLHwung

Q                       A
Fixed Issues? Fixes #13604
Tests Added + Pass? Yes
License MIT

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 31, 2021 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47771/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 31, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c22b024:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@a-tarasyuk a-tarasyuk force-pushed the fix/13520 branch 2 times, most recently from 4ecb14a to eb419e2 Compare July 31, 2021 15:20
@fedeci fedeci added pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: typescript labels Jul 31, 2021
@fedeci fedeci changed the title fix(13520): [ts] export default interface {} should throw fix(ts): raise error for export default interface {} Jul 31, 2021
nicolo-ribaudo
nicolo-ribaudo reviewed Aug 1, 2021
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Except for two minor comments, I think we can modify this PR's implementation to further improve the current generated AST.

packages/babel-parser/src/plugins/typescript/index.js Outdated Show resolved Hide resolved
packages/babel-parser/src/plugins/typescript/index.js Outdated Show resolved Hide resolved
packages/babel-parser/test/fixtures/typescript/interface/export-default/output.json Outdated Show resolved Hide resolved
@a-tarasyuk a-tarasyuk requested a review from fedeci August 1, 2021 15:29
JLHwung
JLHwung approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit b3ab476 into babel:main Aug 2, 2021
This was referenced Aug 5, 2021
Merged
Closed
@doing-art doing-art mentioned this pull request Aug 9, 2021
Closed
1 task
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@fedeci fedeci fedeci approved these changes

@nicolo-ribaudo nicolo-ribaudo Awaiting requested review from nicolo-ribaudo

Assignees
No one assigned
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: export default interface {} should throw
5 participants
@a-tarasyuk @babel-bot @JLHwung @nicolo-ribaudo @fedeci