New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ts] Check if param is assignable when parsing arrow return type #13581
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
...babel-parser/test/fixtures/typescript/arrow-function/arrow-like-in-conditional-4/input.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 0 ? v => (...rest) : v => 0 : v => 0; |
107 changes: 107 additions & 0 deletions
107
...el-parser/test/fixtures/typescript/arrow-function/arrow-like-in-conditional-4/output.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| { | ||
| "type": "File", | ||
| "start":0,"end":37,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":37}}, | ||
| "program": { | ||
| "type": "Program", | ||
| "start":0,"end":37,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":37}}, | ||
| "sourceType": "module", | ||
| "interpreter": null, | ||
| "body": [ | ||
| { | ||
| "type": "ExpressionStatement", | ||
| "start":0,"end":37,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":37}}, | ||
| "expression": { | ||
| "type": "ConditionalExpression", | ||
| "start":0,"end":36,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":36}}, | ||
| "test": { | ||
| "type": "NumericLiteral", | ||
| "start":0,"end":1,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":1}}, | ||
| "extra": { | ||
| "rawValue": 0, | ||
| "raw": "0" | ||
| }, | ||
| "value": 0 | ||
| }, | ||
| "consequent": { | ||
| "type": "ArrowFunctionExpression", | ||
| "start":4,"end":27,"loc":{"start":{"line":1,"column":4},"end":{"line":1,"column":27}}, | ||
| "id": null, | ||
| "generator": false, | ||
| "async": false, | ||
| "params": [ | ||
| { | ||
| "type": "Identifier", | ||
| "start":4,"end":5,"loc":{"start":{"line":1,"column":4},"end":{"line":1,"column":5},"identifierName":"v"}, | ||
| "name": "v" | ||
| } | ||
| ], | ||
| "body": { | ||
| "type": "ArrowFunctionExpression", | ||
| "start":9,"end":27,"loc":{"start":{"line":1,"column":9},"end":{"line":1,"column":27}}, | ||
| "returnType": { | ||
| "type": "TSTypeAnnotation", | ||
| "start":19,"end":22,"loc":{"start":{"line":1,"column":19},"end":{"line":1,"column":22}}, | ||
| "typeAnnotation": { | ||
| "type": "TSTypeReference", | ||
| "start":21,"end":22,"loc":{"start":{"line":1,"column":21},"end":{"line":1,"column":22}}, | ||
| "typeName": { | ||
| "type": "Identifier", | ||
| "start":21,"end":22,"loc":{"start":{"line":1,"column":21},"end":{"line":1,"column":22},"identifierName":"v"}, | ||
| "name": "v" | ||
| } | ||
| } | ||
| }, | ||
| "id": null, | ||
| "generator": false, | ||
| "async": false, | ||
| "params": [ | ||
| { | ||
| "type": "RestElement", | ||
| "start":10,"end":17,"loc":{"start":{"line":1,"column":10},"end":{"line":1,"column":17}}, | ||
| "argument": { | ||
| "type": "Identifier", | ||
| "start":13,"end":17,"loc":{"start":{"line":1,"column":13},"end":{"line":1,"column":17},"identifierName":"rest"}, | ||
| "name": "rest" | ||
| } | ||
| } | ||
| ], | ||
| "body": { | ||
| "type": "NumericLiteral", | ||
| "start":26,"end":27,"loc":{"start":{"line":1,"column":26},"end":{"line":1,"column":27}}, | ||
| "extra": { | ||
| "rawValue": 0, | ||
| "raw": "0" | ||
| }, | ||
| "value": 0 | ||
| } | ||
| } | ||
| }, | ||
| "alternate": { | ||
| "type": "ArrowFunctionExpression", | ||
| "start":30,"end":36,"loc":{"start":{"line":1,"column":30},"end":{"line":1,"column":36}}, | ||
| "id": null, | ||
| "generator": false, | ||
| "async": false, | ||
| "params": [ | ||
| { | ||
| "type": "Identifier", | ||
| "start":30,"end":31,"loc":{"start":{"line":1,"column":30},"end":{"line":1,"column":31},"identifierName":"v"}, | ||
| "name": "v" | ||
| } | ||
| ], | ||
| "body": { | ||
| "type": "NumericLiteral", | ||
| "start":35,"end":36,"loc":{"start":{"line":1,"column":35},"end":{"line":1,"column":36}}, | ||
| "extra": { | ||
| "rawValue": 0, | ||
| "raw": "0" | ||
| }, | ||
| "value": 0 | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "directives": [] | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicolo-ribaudo What about a lookup table? This switch is slow because of 1) string comparison 2) many cases 3) hard to optimize in v8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this switch relies on string comparisons: these strings are always constants in our code so V8 will atomize them and just compare them as pointers (but @JLHwung knows more than me about this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v8 will convert this switch to a lookup, so it's faster if you do it.