Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't insert __self: this within constructors of derived classes (#13550) #13552

Merged
merged 8 commits into from Jul 26, 2021
Merged

Don't insert __self: this within constructors of derived classes (#13550) #13552

merged 8 commits into from Jul 26, 2021
+570 −13

Commits on Jul 25, 2021

  1. Don't insert __self: this prior to super() calls (babel#13550) 

    `__self: this` is inserted for debugging purposes. However, it will cause a runtime error if it is inserted prior to a `super()` call in a constructor. This commit will prevent `__self: this` from inserted when there is a following `super()` call.
    @SCLeoX
    SCLeoX committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    e607821 View commit details
    Browse the repository at this point in the history

  2. Prevent adding __self within a constructor that has super() altog… 

    …ether.
    @SCLeoX
    SCLeoX committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    d8a76ab View commit details
    Browse the repository at this point in the history

  3. Fix 2 typos in the comments.

    @SCLeoX
    SCLeoX committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    79acc89 View commit details
    Browse the repository at this point in the history

  4. Add an additional test case for constructors that do not have a `supe… 

    …r()` call.
    @SCLeoX
    SCLeoX committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    68a43c2 View commit details
    Browse the repository at this point in the history

  5. Detect super() call by testing whether the class has a superclass.

    @SCLeoX
    SCLeoX committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    be997df View commit details
    Browse the repository at this point in the history

  6. Update method name and corresponding comments

    @SCLeoX
    SCLeoX committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    46d3736 View commit details
    Browse the repository at this point in the history

  7. Add an additional test for the case where the derived class do not ha… 

    …ve a `super()` call.
    @SCLeoX
    SCLeoX committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    da310d7 View commit details
    Browse the repository at this point in the history

  8. Apply the same changes to babel-plugin-transform-react-jsx

    @SCLeoX
    SCLeoX committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    e277fc5 View commit details
    Browse the repository at this point in the history