Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: non breaking align options naming #13532

Merged
merged 2 commits into from Aug 19, 2021
Merged

fix: non breaking align options naming #13532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f93f09
Partial #13518
fedeci Jul 6, 2021
8917e57
Update tests
fedeci Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/babel-core/src/transformation/normalize-opts.ts
View file
Open in desktop
Expand Up @@ -30,7 +30,7 @@ export default function normalizeOptions(config: ResolvedConfig): {} {
sourceType:
path.extname(filenameRelative) === ".mjs" ? "module" : sourceType,

sourceFileName: filename,
...(sourceFileName !== "unknown" && { sourceFilename: sourceFileName }),
plugins: [],
...opts.parserOpts,
},
Expand Down
0 ...bel-core/test/fixtures/parse/.babelignore → ...ures/parse/filename-provided/.babelignore
View file
Open in desktop
File renamed without changes.
0 ...s/babel-core/test/fixtures/parse/.babelrc → ...fixtures/parse/filename-provided/.babelrc
View file
Open in desktop
File renamed without changes.
0 ...s/babel-core/test/fixtures/parse/input.js → ...fixtures/parse/filename-provided/input.js
View file
Open in desktop
File renamed without changes.
298 changes: 298 additions & 0 deletions packages/babel-core/test/fixtures/parse/filename-provided/output.json
View file
Open in desktop
@@ -0,0 +1,298 @@
{
"type": "File",
"start": 0,
"end": 91,
"errors": [],
"loc": {
"filename": "input.js",
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 7,
"column": 0
}
},
"program": {
"type": "Program",
"start": 0,
"end": 91,
"loc": {
"filename": "input.js",
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 7,
"column": 0
}
},
"interpreter": null,
"sourceType": "module",
"body": [{
"type": "ClassDeclaration",
"start": 0,
"end": 29,
"loc": {
"filename": "input.js",
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 2,
"column": 17
}
},
"decorators": [{
"type": "Decorator",
"start": 0,
"end": 11,
"loc": {
"filename": "input.js",
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 11
}
},
"expression": {
"type": "Identifier",
"start": 1,
"end": 11,
"loc": {
"filename": "input.js",
"start": {
"line": 1,
"column": 1
},
"end": {
"line": 1,
"column": 11
},
"identifierName": "annotation"
},
"name": "annotation"
}
}],
"id": {
"type": "Identifier",
"start": 18,
"end": 25,
"loc": {
"filename": "input.js",
"start": {
"line": 2,
"column": 6
},
"end": {
"line": 2,
"column": 13
},
"identifierName": "MyClass"
},
"name": "MyClass"
},
"superClass": null,
"body": {
"type": "ClassBody",
"start": 26,
"end": 29,
"loc": {
"filename": "input.js",
"start": {
"line": 2,
"column": 14
},
"end": {
"line": 2,
"column": 17
}
},
"body": []
}
},
{
"type": "FunctionDeclaration",
"start": 31,
"end": 90,
"loc": {
"filename": "input.js",
"start": {
"line": 4,
"column": 0
},
"end": {
"line": 6,
"column": 1
}
},
"id": {
"type": "Identifier",
"start": 40,
"end": 50,
"loc": {
"filename": "input.js",
"start": {
"line": 4,
"column": 9
},
"end": {
"line": 4,
"column": 19
},
"identifierName": "annotation"
},
"name": "annotation"
},
"generator": false,
"async": false,
"params": [{
"type": "Identifier",
"start": 51,
"end": 57,
"loc": {
"filename": "input.js",
"start": {
"line": 4,
"column": 20
},
"end": {
"line": 4,
"column": 26
},
"identifierName": "target"
},
"name": "target"
}],
"body": {
"type": "BlockStatement",
"start": 59,
"end": 90,
"loc": {
"filename": "input.js",
"start": {
"line": 4,
"column": 28
},
"end": {
"line": 6,
"column": 1
}
},
"body": [{
"type": "ExpressionStatement",
"start": 64,
"end": 88,
"loc": {
"filename": "input.js",
"start": {
"line": 5,
"column": 3
},
"end": {
"line": 5,
"column": 27
}
},
"expression": {
"type": "AssignmentExpression",
"start": 64,
"end": 87,
"loc": {
"filename": "input.js",
"start": {
"line": 5,
"column": 3
},
"end": {
"line": 5,
"column": 26
}
},
"operator": "=",
"left": {
"type": "MemberExpression",
"start": 64,
"end": 80,
"loc": {
"filename": "input.js",
"start": {
"line": 5,
"column": 3
},
"end": {
"line": 5,
"column": 19
}
},
"object": {
"type": "Identifier",
"start": 64,
"end": 70,
"loc": {
"filename": "input.js",
"start": {
"line": 5,
"column": 3
},
"end": {
"line": 5,
"column": 9
},
"identifierName": "target"
},
"name": "target"
},
"property": {
"type": "Identifier",
"start": 71,
"end": 80,
"loc": {
"filename": "input.js",
"start": {
"line": 5,
"column": 10
},
"end": {
"line": 5,
"column": 19
},
"identifierName": "annotated"
},
"name": "annotated"
},
"computed": false
},
"right": {
"type": "BooleanLiteral",
"start": 83,
"end": 87,
"loc": {
"filename": "input.js",
"start": {
"line": 5,
"column": 22
},
"end": {
"line": 5,
"column": 26
}
},
"value": true
}
}
}],
"directives": []
}
}
],
"directives": []
},
"comments": []
}
6 changes: 6 additions & 0 deletions packages/babel-core/test/fixtures/parse/passed-in-configuration/input.js
View file
Open in desktop
@@ -0,0 +1,6 @@
@annotation
class MyClass { }

function annotation(target) {
target.annotated = true;
}
0 ...abel-core/test/fixtures/parse/output.json → ...parse/passed-in-configuration/output.json
View file
Open in desktop
File renamed without changes.
Empty file added packages/babel-core/test/fixtures/parse/sourceFileName-provided/.babelignore
View file
Open in desktop
Empty file.
5 changes: 5 additions & 0 deletions packages/babel-core/test/fixtures/parse/sourceFileName-provided/.babelrc
View file
Open in desktop
@@ -0,0 +1,5 @@
{
"parserOpts": {
"plugins": ["decorators-legacy"]
}
}
6 changes: 6 additions & 0 deletions packages/babel-core/test/fixtures/parse/sourceFileName-provided/input.js
View file
Open in desktop
@@ -0,0 +1,6 @@
@annotation
class MyClass { }

function annotation(target) {
target.annotated = true;
}