Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul comment attachment #13521

Merged
merged 35 commits into from Jul 7, 2021
Merged

Commits on Jul 7, 2021

  1. refactor: inline pushComment

    JLHwung committed Jul 7, 2021
    Copy the full SHA
    64cc20e View commit details
    Browse the repository at this point in the history
  2. chore: add benchmark cases

    JLHwung committed Jul 7, 2021
    Copy the full SHA
    b20fffa View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    a557f5b View commit details
    Browse the repository at this point in the history
  4. cleanup

    JLHwung committed Jul 7, 2021
    Copy the full SHA
    555687b View commit details
    Browse the repository at this point in the history
  5. update test fixtures

    They are all bugfixes.
    JLHwung committed Jul 7, 2021
    Copy the full SHA
    fc79aa5 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    add886e View commit details
    Browse the repository at this point in the history
  7. perf: remove unattachedCommentStack

    baseline 128 nested leading comments: 11_034 ops/sec ±50.64% (0.091ms)
    baseline 256 nested leading comments: 6_037 ops/sec ±11.46% (0.166ms)
    baseline 512 nested leading comments: 3_077 ops/sec ±2.31% (0.325ms)
    baseline 1024 nested leading comments: 1_374 ops/sec ±3.22% (0.728ms)
    current 128 nested leading comments: 11_027 ops/sec ±37.41% (0.091ms)
    current 256 nested leading comments: 6_736 ops/sec ±1.39% (0.148ms)
    current 512 nested leading comments: 3_306 ops/sec ±0.69% (0.302ms)
    current 1024 nested leading comments: 1_579 ops/sec ±2.09% (0.633ms)
    
    baseline 128 nested trailing comments: 10_073 ops/sec ±42.95% (0.099ms)
    baseline 256 nested trailing comments: 6_294 ops/sec ±2.19% (0.159ms)
    baseline 512 nested trailing comments: 3_041 ops/sec ±0.8% (0.329ms)
    baseline 1024 nested trailing comments: 1_530 ops/sec ±1.18% (0.654ms)
    current 128 nested trailing comments: 11_461 ops/sec ±44.89% (0.087ms)
    current 256 nested trailing comments: 7_212 ops/sec ±1.6% (0.139ms)
    current 512 nested trailing comments: 3_403 ops/sec ±1% (0.294ms)
    current 1024 nested trailing comments: 1_539 ops/sec ±1.49% (0.65ms)
    JLHwung committed Jul 7, 2021
    Copy the full SHA
    d10e583 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    54e7974 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    1366fc6 View commit details
    Browse the repository at this point in the history
  10. add test case for babel#11576

    JLHwung committed Jul 7, 2021
    Copy the full SHA
    ac59810 View commit details
    Browse the repository at this point in the history
  11. Copy the full SHA
    664af02 View commit details
    Browse the repository at this point in the history
  12. Copy the full SHA
    60bfe39 View commit details
    Browse the repository at this point in the history
  13. Copy the full SHA
    140f93c View commit details
    Browse the repository at this point in the history
  14. docs: update comments

    JLHwung committed Jul 7, 2021
    Copy the full SHA
    d0a8f4a View commit details
    Browse the repository at this point in the history
  15. add a new benchmark

    JLHwung committed Jul 7, 2021
    Copy the full SHA
    1d401c6 View commit details
    Browse the repository at this point in the history
  16. Copy the full SHA
    b499b03 View commit details
    Browse the repository at this point in the history
  17. add more benchmark cases

    JLHwung committed Jul 7, 2021
    Copy the full SHA
    e0e5e11 View commit details
    Browse the repository at this point in the history
  18. Copy the full SHA
    30a62e9 View commit details
    Browse the repository at this point in the history
  19. Copy the full SHA
    3350289 View commit details
    Browse the repository at this point in the history
  20. add testcase about directive

    JLHwung committed Jul 7, 2021
    Copy the full SHA
    b3c06de View commit details
    Browse the repository at this point in the history
  21. Copy the full SHA
    1c65383 View commit details
    Browse the repository at this point in the history
  22. chore: rename test cases

    JLHwung committed Jul 7, 2021
    Copy the full SHA
    a3188ef View commit details
    Browse the repository at this point in the history
  23. Copy the full SHA
    3ec0b25 View commit details
    Browse the repository at this point in the history
  24. Copy the full SHA
    79cb035 View commit details
    Browse the repository at this point in the history
  25. Copy the full SHA
    e02d6bd View commit details
    Browse the repository at this point in the history
  26. misc fix

    JLHwung committed Jul 7, 2021
    Copy the full SHA
    c3b2fea View commit details
    Browse the repository at this point in the history
  27. Copy the full SHA
    7ae3f42 View commit details
    Browse the repository at this point in the history
  28. Copy the full SHA
    0981f2e View commit details
    Browse the repository at this point in the history
  29. fix flow errors

    JLHwung committed Jul 7, 2021
    Copy the full SHA
    9e1b04b View commit details
    Browse the repository at this point in the history
  30. Copy the full SHA
    b28aba1 View commit details
    Browse the repository at this point in the history
  31. Copy the full SHA
    6ac270c View commit details
    Browse the repository at this point in the history
  32. fix flow errors

    JLHwung committed Jul 7, 2021
    Copy the full SHA
    cdf6b4f View commit details
    Browse the repository at this point in the history
  33. Copy the full SHA
    fb29d75 View commit details
    Browse the repository at this point in the history
  34. Copy the full SHA
    430b3e0 View commit details
    Browse the repository at this point in the history
  35. update test fixtures

    JLHwung committed Jul 7, 2021
    Copy the full SHA
    4f076f8 View commit details
    Browse the repository at this point in the history