Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking(babel-8): align options naming #13518

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

fedeci
Copy link
Member

@fedeci fedeci commented Jun 28, 2021

Q                       A
Fixed Issues? Part of #13170
Patch: Bug Fix?
Major: Breaking Change? Yes
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Since Babel 8 should be released relatively soon, I am not sure we should already add support for this breaking change in v7.15.


edit: rebased on top of #13532

@babel-bot
Copy link
Collaborator

babel-bot commented Jun 28, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47768/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 28, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5e1649b:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@hzoo
Copy link
Member

hzoo commented Jun 28, 2021

Should we continue these changes under the BABEL_8_BREAKING flag like the those?

@fedeci
Copy link
Member Author

fedeci commented Jun 28, 2021

Maybe yes, but what benefits would that bring? We only put more effort in handling a double source of truth for probably a couple of months(?)

@nicolo-ribaudo
Copy link
Member

If you prefer we can keep this as-is, and wait merging it until Babel 8.

@fedeci
Copy link
Member Author

fedeci commented Jun 29, 2021

Yes, I think it would be more sustainable.
Instead, this is a bug that should be addressed in v7.15, even if it may be a breaking change for someone.

@hzoo
Copy link
Member

hzoo commented Jun 29, 2021

Ok I just wanted too to check we were ok with it, it's a pretty small scope change otherwise? It wouldn't be great if it broke in a dep that caused issues for people but that seems unlikely?

@fedeci
Copy link
Member Author

fedeci commented Jun 29, 2021

I'm not sure if that small change broke the entire CRA e2e. I'll investigate tomorrow.

fedeci added a commit to fedeci/babel that referenced this pull request Jul 6, 2021
@fedeci fedeci added the PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release label Jul 6, 2021
@fedeci fedeci added this to the Babel 8.0 milestone Jul 6, 2021
fedeci added a commit to fedeci/babel that referenced this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants