New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking(babel-8): align options naming #13518
base: main
Are you sure you want to change the base?
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47768/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5e1649b:
|
Should we continue these changes under the BABEL_8_BREAKING flag like the those? |
Maybe yes, but what benefits would that bring? We only put more effort in handling a double source of truth for probably a couple of months(?) |
If you prefer we can keep this as-is, and wait merging it until Babel 8. |
Yes, I think it would be more sustainable. |
Ok I just wanted too to check we were ok with it, it's a pretty small scope change otherwise? It wouldn't be great if it broke in a dep that caused issues for people but that seems unlikely? |
I'm not sure if that small change broke the entire CRA e2e. I'll investigate tomorrow. |
0003821
to
3b3dacb
Compare
3b3dacb
to
5e1649b
Compare
* Partial #13518 * Update tests
Since Babel 8 should be released relatively soon, I am not sure we should already add support for this breaking change in v7.15.
edit: rebased on top of #13532