Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config validation message typo #13515

Merged
merged 2 commits into from Jun 29, 2021
Merged

Fix config validation message typo #13515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5e27f5
Fix config validation message typo
jaeseokk Jun 28, 2021
b8d5987
Fix `checkNoUnwrappedItemOptionPairs` type param
jaeseokk Jun 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/babel-core/src/config/validation/options.ts
View file
Open in desktop
Expand Up @@ -455,7 +455,7 @@ export function checkNoUnwrappedItemOptionPairs(
) {
e.message +=
`\n- Maybe you meant to use\n` +
`"${type}": [\n ["${lastItem.file.request}", ${JSON.stringify(
`"${type}s": [\n ["${lastItem.file.request}", ${JSON.stringify(
thisItem.value,
undefined,
2,
Expand Down
6 changes: 3 additions & 3 deletions packages/babel-core/test/__snapshots__/option-manager.js.snap
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@
exports[`option-manager config plugin/preset flattening and overriding should throw when an option is following a preset 1`] = `
"[BABEL] unknown: Unknown option: .useSpread. Check out https://babeljs.io/docs/en/babel-core/#options for more information about options.
- Maybe you meant to use
\\"preset\\": [
\\"presets\\": [
[\\"./fixtures/option-manager/babel-preset-bar\\", {
\\"useSpread\\": true
}]
Expand All @@ -14,7 +14,7 @@ To be a valid preset, its name and options should be wrapped in a pair of bracke
exports[`option-manager config plugin/preset flattening and overriding should throw when an option is provided as a plugin 1`] = `
"[BABEL] unknown: .useSpread is not a valid Plugin property
- Maybe you meant to use
\\"plugin\\": [
\\"plugins\\": [
[\\"./fixtures/option-manager/babel-plugin-foo\\", {
\\"useSpread\\": true
}]
Expand All @@ -25,7 +25,7 @@ To be a valid plugin, its name and options should be wrapped in a pair of bracke
exports[`option-manager config plugin/preset flattening and overriding should throw when an option is provided as a preset 1`] = `
"[BABEL] unknown: Unknown option: .useBuiltIns. Check out https://babeljs.io/docs/en/babel-core/#options for more information about options.
- Maybe you meant to use
\\"preset\\": [
\\"presets\\": [
[\\"./fixtures/option-manager/babel-preset-bar\\", {
\\"useBuiltIns\\": \\"entry\\"
}]
Expand Down