Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(parser): add test to handle optional paramteter in async call #13504

Merged
merged 3 commits into from Jun 23, 2021
Merged

chore(parser): add test to handle optional paramteter in async call #13504

merged 3 commits into from Jun 23, 2021

Conversation

tony-go
Copy link
Contributor

@tony-go tony-go commented Jun 23, 2021 •
edited by JLHwung

Q                       A
Fixed Issues? Resolves #13446
Patch: Bug Fix? ⛔
Major: Breaking Change? ⛔
Minor: New Feature? ⛔
Tests Added + Pass? 👍
Documentation PR Link ⛔
Any Dependency Changes? ⛔
License MIT

Adding test for this case:

async(x?)
  • in js -> should throw
  • in flow -> should parse
  • in typescript -> should parse

@babel-bot
Copy link
Collaborator

babel-bot commented Jun 23, 2021 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47079/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 23, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0f0b17e:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@tony-go tony-go marked this pull request as ready for review June 23, 2021 14:09
JLHwung
JLHwung approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JLHwung JLHwung merged commit b0fe6bd into babel:main Jun 23, 2021
nicolo-ribaudo pushed a commit to nicolo-ribaudo/babel that referenced this pull request Jul 30, 2021
@tony-go @nicolo-ribaudo
chore(parser): add test to handle optional paramteter in async call (b…
6439706 
…abel#13504)

* chore(parser): add test to handle optional paramteter in async call

* chore(parser): add flow test

* chore(parser): add ts test
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
area: tests outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: async(x?) should throw
4 participants
@tony-go @babel-bot @existentialism @JLHwung