New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't hoist template literal keys in object-rest-spread
#13483
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
...t-spread/test/fixtures/object-rest/template-literal-allLiterals-true-no-hoisting/input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
const example = () => { | ||
const input = {}; | ||
const foo = 'foo'; | ||
|
||
({ | ||
[`${foo}_bar`]: country, | ||
...rest | ||
} = input); | ||
} |
10 changes: 10 additions & 0 deletions
10
...-spread/test/fixtures/object-rest/template-literal-allLiterals-true-no-hoisting/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
const example = () => { | ||
const input = {}; | ||
const foo = 'foo'; | ||
var _input = input; | ||
({ | ||
[`${foo}_bar`]: country | ||
} = _input); | ||
rest = babelHelpers.objectWithoutProperties(_input, [`${foo}_bar`]); | ||
_input; | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This flag is kinda redundant, you could just set
allLiteral = false
(becaseTemplateLiteral
is most often not literal). Or remove this branch, replace the following condition'sisLiteral
withisImmutable
, and thenTemplateLiteral
would fall through to theelse
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because when
allLiteral
isfalse
we need to inject thetoPropertyKey
helper. We don't need it if we have template literals.