Add support for rhino as a compilation target #13448

gausie · 2021-06-10T09:09:32Z

Q	A
Fixed Issues?	Fixes #2537 (sort of)
Patch: Bug Fix?	No
Major: Breaking Change?	No
Minor: New Feature?	👍
Tests Added + Pass?	Not sure where they would go
Documentation PR Link	As far as I can see, we don't really need to add any
Any Dependency Changes?	No
License	MIT

As suggested by @nicolo-ribaudo in mozilla/rhino#661, I've updated compat-table to fully represent the latest version of Rhino and this PR should mean that we can now start targeting it with babel!

codesandbox-ci · 2021-06-10T09:13:33Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8ac5af5:

Sandbox	Source
babel-repl-custom-plugin	Configuration
babel-plugin-multi-config	Configuration

babel-bot · 2021-06-10T09:13:54Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47047/

zloirock · 2021-06-10T09:17:23Z

Could you run core-js-compat test case and add a PR to core-js too?

gausie · 2021-06-10T10:49:25Z

Could you run core-js-compat test case and add a PR to core-js too?

Unfortunately Rhino can't really even run the test runner core-js uses (at least via my naive attempt). Would it be ok to merge this before getting that sorted or are they both needed concurrently?

zloirock · 2021-06-10T10:54:30Z

@gausie you could check the source of the test runner and adapt it to Rhino - it's just some lines. It's required for proper built-ins injection by preset-env, however, it's not a block for this PR.

gausie · 2021-06-10T11:06:08Z

@zloirock Sure, I'll adapt in my local copy for rhino, get the data and discard my edits.

zloirock · 2021-06-10T11:14:45Z

@gausie you could add a Rhino runner to the PR like in compat-table - it could simplify adding new data in the future -)

gausie · 2021-06-10T11:19:18Z

@gausie you could add a Rhino runner to the PR like in compat-table - it could simplify adding new data in the future -)

I think I'll just fix the two issues in Rhino!

gausie · 2021-06-10T11:39:08Z

Here's that PR: zloirock/core-js#942

gausie · 2021-06-10T18:08:22Z

@zloirock whats up with these two in-progress ci jobs? Are they waiting for approval to start somehow?

zloirock · 2021-06-10T18:24:57Z

I think that it could be better to ask @nicolo-ribaudo since I'm not an expert in current CI.

nicolo-ribaudo · 2021-06-10T20:24:21Z

We only run them manually when changing code that only affects Babel 8 or that might affect spec compliancy of our plugin.

gausie · 2021-06-10T21:10:45Z

Ahha! Well this ain't that 😛

nicolo-ribaudo

Could you also add a test in babel-preset-env/tests/fixtures to make sure that the rhino target works?

JLHwung · 2021-06-12T13:08:00Z

We need to bump core-js-compat when zloirock/core-js#942 is published.

gausie · 2021-06-21T13:54:58Z

@JLHwung that has now landed in core-js v3.15.0

gausie · 2021-06-21T14:03:07Z

Ok I've bumped core-js-compat but unsure if I should have bumped core-js too, so I've left it.

nicolo-ribaudo · 2021-06-21T14:04:38Z

@gausie I'm preparing a PR to bump all the core-js packages. I prefer to keep it separate from this one because this PR will be merged in the next minor, while bumping core-js is more urgent otherwise our e2e tests will start failing.

gausie · 2021-06-21T14:05:47Z

@nicolo-ribaudo ok, is bumping core-js-compat as I have done ok, or should I undo that last commit?

nicolo-ribaudo · 2021-06-21T14:07:01Z

We'll ask you to rebase this PR on main after #13491 is merged (or to merge main in this PR), so reverting the last commit is not necessary but might make it easier to rebase later.

nicolo-ribaudo · 2021-06-21T14:08:23Z

I just saw compat-table/compat-table#1731. Maybe for the same reason we should have Rhino patch versions in our data? We might need to update our build script to support them.

gausie · 2021-06-21T14:30:42Z

@nicolo-ribaudo Adding in that patch release is easy since every 1.7 would just need the same change, but I'm not sure how I'd go about updating the build scripts.

nicolo-ribaudo · 2021-06-21T14:39:17Z

Mmh, looking at our build script it looks like it should already work 🤔 Could you try updating the COMPAT_TABLE hash, and let's see if it works.

Btw, we just merged #13491 into main.

gausie · 2021-06-21T14:46:20Z

@nicolo-ribaudo Ok that's all done now

packages/babel-preset-env/test/fixtures/preset-options-babel-7/rhino-1_7/input.mjs

…de syntax that is and isn't supported for better testing

nicolo-ribaudo

Sorry, I was not clear enough in my previous comment 😅

packages/babel-compat-data/scripts/data/plugin-features.js

…-classes

JLHwung

Does rhino support ES Modules? I searched its repo and it seems to me rhino only supports commonjs. If I am wrong, we should also update packages/babel-compat-data/scripts/build-modules-support.js, otherwise this PR lgtm.

gausie · 2021-06-23T08:12:51Z

Does rhino support ES Modules? I searched its repo and it seems to me rhino only supports commonjs. If I am wrong, we should also update packages/babel-compat-data/scripts/build-modules-support.js, otherwise this PR lgtm.

You're correct, for now it only supports commonjs. Woop!

nicolo-ribaudo

Thanks! We'll merge this for the next minor release, somewhere in July.

nicolo-ribaudo · 2021-08-03T21:03:08Z

We'll release 7.15 this week. Thank you!

Add support for rhino as a compilation target

e0daec9

gausie mentioned this pull request Jun 10, 2021

Question: Is there a recommended version of babel preset env to use when transpiling down ES2020 features? mozilla/rhino#661

Closed

nicolo-ribaudo added pkg: compat-data pkg: preset-env PR: New Feature 🚀 A type of pull request used for our changelog categories labels Jun 10, 2021

zloirock approved these changes Jun 10, 2021

View reviewed changes

nicolo-ribaudo reviewed Jun 10, 2021

View reviewed changes

Add tests for target: rhino

2a0537c

gausie requested a review from nicolo-ribaudo June 11, 2021 09:42

gausie added 2 commits June 14, 2021 18:02

Fix test failing due to whitespace

33f853a

Keep consistent names for rhino tests in babel 7 and 8

01c751e

Bump core-js-compat to 3.15.0

aa98b1c

Merge branch 'main' into rhino-support

e06683d

nicolo-ribaudo added this to the v7.15.0 milestone Jun 21, 2021

gausie added 2 commits June 21, 2021 15:40

Merge branch 'main' into rhino-support

8e8d220

Change references to rhino to include patch version

1b4b378

nicolo-ribaudo reviewed Jun 21, 2021

View reviewed changes

packages/babel-preset-env/test/fixtures/preset-options-babel-7/rhino-1_7/input.mjs Outdated Show resolved Hide resolved

p-bakker mentioned this pull request Jun 22, 2021

Is there a Babel preset for Ringo (Rhino?) ringo/ringojs#418

Closed

gausie added 4 commits June 22, 2021 10:41

Merge branch 'main' into rhino-support

78fbb17

Update compat table data import

f9ad8e9

Split transpilation of arrow function features more finely

47304da

Rename rhino fixtures to include the patch number and update to inclu…

07928a2

…de syntax that is and isn't supported for better testing

nicolo-ribaudo reviewed Jun 22, 2021

View reviewed changes

packages/babel-compat-data/scripts/data/plugin-features.js Outdated Show resolved Hide resolved

packages/babel-compat-data/scripts/data/plugin-features.js Outdated Show resolved Hide resolved

Only use the relevant features for transform-new-target and transform…

8ac5af5

…-classes

JLHwung approved these changes Jun 22, 2021

View reviewed changes

gausie requested a review from nicolo-ribaudo June 23, 2021 08:14

nicolo-ribaudo approved these changes Jun 23, 2021

View reviewed changes

nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Jun 23, 2021

nicolo-ribaudo merged commit 830b99d into babel:main Aug 3, 2021

This was referenced Aug 5, 2021

chore(deps-dev): bump @babel/eslint-parser from 7.13.14 to 7.15.0 filecoin-project/slate#863

Merged

chore(deps-dev): bump @babel/core from 7.13.14 to 7.15.0 filecoin-project/slate#862

Closed

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 3, 2021

github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for rhino as a compilation target #13448

Add support for rhino as a compilation target #13448

gausie commented Jun 10, 2021 •

edited

codesandbox-ci bot commented Jun 10, 2021 •

edited

babel-bot commented Jun 10, 2021 •

edited

zloirock commented Jun 10, 2021 •

edited

gausie commented Jun 10, 2021

zloirock commented Jun 10, 2021 •

edited

gausie commented Jun 10, 2021

zloirock commented Jun 10, 2021 •

edited

gausie commented Jun 10, 2021

gausie commented Jun 10, 2021

gausie commented Jun 10, 2021 •

edited

zloirock commented Jun 10, 2021

nicolo-ribaudo commented Jun 10, 2021

gausie commented Jun 10, 2021

nicolo-ribaudo left a comment

JLHwung commented Jun 12, 2021

gausie commented Jun 21, 2021

gausie commented Jun 21, 2021

nicolo-ribaudo commented Jun 21, 2021

gausie commented Jun 21, 2021

nicolo-ribaudo commented Jun 21, 2021

nicolo-ribaudo commented Jun 21, 2021

gausie commented Jun 21, 2021

nicolo-ribaudo commented Jun 21, 2021 •

edited

gausie commented Jun 21, 2021

nicolo-ribaudo left a comment

JLHwung left a comment

gausie commented Jun 23, 2021

nicolo-ribaudo left a comment

nicolo-ribaudo commented Aug 3, 2021

Add support for rhino as a compilation target #13448

Add support for rhino as a compilation target #13448

Conversation

gausie commented Jun 10, 2021 • edited

codesandbox-ci bot commented Jun 10, 2021 • edited

babel-bot commented Jun 10, 2021 • edited

zloirock commented Jun 10, 2021 • edited

gausie commented Jun 10, 2021

zloirock commented Jun 10, 2021 • edited

gausie commented Jun 10, 2021

zloirock commented Jun 10, 2021 • edited

gausie commented Jun 10, 2021

gausie commented Jun 10, 2021

gausie commented Jun 10, 2021 • edited

zloirock commented Jun 10, 2021

nicolo-ribaudo commented Jun 10, 2021

gausie commented Jun 10, 2021

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

JLHwung commented Jun 12, 2021

gausie commented Jun 21, 2021

gausie commented Jun 21, 2021

nicolo-ribaudo commented Jun 21, 2021

gausie commented Jun 21, 2021

nicolo-ribaudo commented Jun 21, 2021

nicolo-ribaudo commented Jun 21, 2021

gausie commented Jun 21, 2021

nicolo-ribaudo commented Jun 21, 2021 • edited

gausie commented Jun 21, 2021

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

JLHwung left a comment

Choose a reason for hiding this comment

gausie commented Jun 23, 2021

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

nicolo-ribaudo commented Aug 3, 2021

gausie commented Jun 10, 2021 •

edited

codesandbox-ci bot commented Jun 10, 2021 •

edited

babel-bot commented Jun 10, 2021 •

edited

zloirock commented Jun 10, 2021 •

edited

zloirock commented Jun 10, 2021 •

edited

zloirock commented Jun 10, 2021 •

edited

gausie commented Jun 10, 2021 •

edited

nicolo-ribaudo commented Jun 21, 2021 •

edited