Disallow dependency cycles #13442
Disallow dependency cycles #13442
Conversation
nicolo-ribaudo
added
PR: Internal 🏠
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0e454a1:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46760/ |
| "@babel/types": "workspace:^7.13.16" | ||
| }, | ||
| "TODO": "The @babel/traverse dependency is only needed for the NodePath TS type. We can consider exporting it from @babel/core.", | ||
| "devDependencies": { | ||
| "@babel/traverse": "workspace:*" |
There was a problem hiding this comment.
Traverse is only used for a type import:
babel/packages/babel-helper-hoist-variables/src/index.ts
Lines 1 to 3 in d3f4c22
There was a problem hiding this comment.
command at nicolo-ribaudo/yarn-plugin-babel-release-tool@e0194c8
looks good if CI passes
|
It seems that this also fixes the failures on The "publish verdaccio" step was taking 5 hours (and then it was killed) because of an infinite loop in cycle detection, fixed by nicolo-ribaudo/yarn-plugin-babel-release-tool@e0194c8#diff-84e45058636f9e228c1d37fa19e6c943a505efa6e144a64ebb25df629233ff84R134-R135. |
github-actions
bot
added
the
outdated
We currently cannot publish because of a cycle. I'll push the cycle fix here, but first I want to see CI failing.