Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the "Hack" pipeline proposal (#13191) #13413

Merged
merged 5 commits into from
Aug 3, 2021
Merged

Add support for the "Hack" pipeline proposal (#13191) #13413

merged 5 commits into from
Aug 3, 2021

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jun 2, 2021 •
edited

⚠️ Use "Rebase and Merge"!

@nicolo-ribaudo nicolo-ribaudo added this to the v7.15.0 milestone Jun 2, 2021
@babel-bot
Copy link
Collaborator

babel-bot commented Jun 2, 2021 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47626/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 2, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c29531e:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Jun 7, 2021
Merged
@nicolo-ribaudo
Copy link
Member Author

@js-choi I rebased this branch to fix the CI failure.

Could you rebase #13416 on top of this? You might need to do an interactive rebase to make sure not to duplicate the two commits already in this branch.

@js-choi js-choi mentioned this pull request Jun 9, 2021
Merged
@js-choi
Copy link
Contributor

js-choi commented Jun 9, 2021 •
edited

@nicolo-ribaudo: I have squashed and rebased #13416 onto this branch.

After #13416, there will need to be one more pull request to apply BABEL_8_BREAKING to the deprecated smart-mix pipes. [Edit: This deprecation is ready to merge in #13488.]

@js-choi js-choi mentioned this pull request Jun 19, 2021
Closed
@js-choi
Copy link
Contributor

js-choi commented Jul 4, 2021 •
edited

The feat-7.15.0/hack-pipes branch now has conflicts with the main branch. I am planning to make another pull request to feat-7.15.0/hack-pipes (based on #13488, which in turn is based on #13416) that resolves its conflicts and rebases it on main.

@nicolo-ribaudo
Copy link
Member Author

@js-choi I just merged your second PR and I'll rebase this to solve the conflicts. It's unlikely that your next PR will be merged before Babel 7.15.0, so unless you need to rebase it for some reason you could wait until this is merged to main.

The next PR (the one that disables the smart proposal for Babel 8) can even be merged in a patch anyway.

@js-choi
Copy link
Contributor

js-choi commented Jul 6, 2021 •
edited

@nicolo-ribaudo: Sounds good; thank you for reviewing and rebasing. As you say, the smart-mix deprecation PR can be put in v7.15.1 or whatever, but is this PR still on track for v7.15.0?

@nicolo-ribaudo
Copy link
Member Author

Yes exactly. Smart mix will be removed behind a build-time flag that we'll toggle in Babel 8, so it doesn't matter when we merge it.

@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Jul 6, 2021
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Jul 7, 2021
Merged
@nicolo-ribaudo nicolo-ribaudo removed the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Jul 7, 2021
@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Jul 20, 2021
js-choi and others added 5 commits August 3, 2021 23:12
@js-choi @nicolo-ribaudo
Add support for the "Hack" pipeline proposal (#13191)
c63b17f 
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
@js-choi @nicolo-ribaudo
parser: Fix Hack/smart-pipe error positions (#13426)
e50a602
@js-choi @fedeci @nicolo-ribaudo
Hack-pipe proposal with % topic token (#13416)
a732128 
Co-authored-by: Federico Ciardi <fed.ciardi@gmail.com>
@nicolo-ribaudo @JLHwung @js-choi
Fix %== parsing in hack pipes (#13536)
24e4250 
* Fix `%==` parsing in hack pipes

* Use custom token type

* Update packages/babel-parser/src/parser/expression.js

Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>

* Apply suggestions from code review

Co-authored-by: J. S. Choi <jschoi@jschoi.org>

Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
Co-authored-by: J. S. Choi <jschoi@jschoi.org>
@JLHwung @nicolo-ribaudo
feat: support hack pipeline in @babel/standalone (#13555)
c29531e
@nicolo-ribaudo nicolo-ribaudo merged commit 15f2f17 into main Aug 3, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the feat-7.15.0/hack-pipes branch August 3, 2021 21:30
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release umbrella ☂️
Projects
None yet
Milestone
v7.15.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicolo-ribaudo @babel-bot @js-choi @JLHwung