New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: throw when async()
call param is object with assignement
#13410
fix: throw when async()
call param is object with assignement
#13410
Conversation
…ttern in async call
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46657/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1183a3c:
|
...l-parser/test/fixtures/es2017/async-call/parenthesized-argument-object-double-proto/input.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
async()
call param is object with assignement
Hi there 👋 ,
After few hours exploring
babel-parser
I open this draft pull request.Let me know what do you think about the code.
Input code:
Before: was parsed without error 🤮
After: throw an error as expected 🎉
Note: I got an error running all tests
But it seems to be there even on
main
branch .