Skip flow/typecasts/3 test on Node.js 6
#13382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46500/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5a5e719:
|
|
Oh I don't see this one when opening #13383 |
|
Sidenote: Node.js 6 (V8 5.1) uses crankshaft: https://v8.dev/blog/launching-ignition-and-turbofan , which is why I don't bother creating a V8 issue on that. |
|
I don't have a preference for either PR. We could either merge yours, or merge this and fix it later in a patch with yours if someone finds that the v8 bug happens also outside from our test suite. |
JLHwung
approved these changes
May 27, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js 6 has a bug which causes some booleans to be flipped when V8 5.1 compiles the code with TurboFan (the optimizing compiler).
This is very unlikely to affect our users, since no one parses as many files as we do in our parser tests, and it only affects Node.js 6. Let's just skip the test for now so that CI stops failing.