fix: preserve tokensLength in tryParse #13326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Bug Fix 🐛
JLHwung
commented
May 17, 2021
| @@ -0,0 +1 @@ | |||
| <div propA={[key: value]} /> | |||
There was a problem hiding this comment.
Currently the tokens of parsed AST is a length-14 array
[ tt.jsxTagStart, tt.name, undefined, undefined, ... , tt.eof]babel7Compat thus throws because the tokens unexpectedly includes undefined.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46182/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6f84912:
|
nicolo-ribaudo
approved these changes
May 17, 2021
existentialism
approved these changes
May 17, 2021
Co-authored-by: Brian Ng <bng412@gmail.com>
This was referenced May 26, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we preserve
state.tokensLength(derived fromthis.tokens) on raising errors whenerrorRecovery: true, because the parser will parse remaining tokens. We do not reset the parser state whentryParsesuccessfully returns, so whenerrorRecoveryistrue, we should not resetstate.tokensLength, too.Technically #13256 does not introduce this regression but it reveals the fact that the parser unexpectedly eats tokens when errors are thrown in recovery mode.