Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse attributes of import expression with estree plugin #13284

Merged
merged 3 commits into from May 7, 2021
Merged

Parse attributes of import expression with estree plugin #13284

merged 3 commits into from May 7, 2021

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented May 7, 2021 •
edited by gitpod-io bot

Q                       A
Fixed Issues? Fixes #13280
Patch: Bug Fix? Y
Tests Added + Pass? Yes
License MIT

@sosukesuzuki sosukesuzuki added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser area: estree Spec: Import Attributes labels May 7, 2021
JLHwung
JLHwung approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@babel-bot
Copy link
Collaborator

babel-bot commented May 7, 2021 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45939/

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 7, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6badd7e:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@sosukesuzuki @JLHwung
Update packages/babel-parser/src/types.js
6badd7e 
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
@nicolo-ribaudo
Copy link
Member

"Bug Fix" might be a bit of a stretch here, but I can convince myself that this isn't a new feature by saying that we were already parsing the import attributes but accidentally dropping them completely from the AST 🤷

@JLHwung JLHwung merged commit 1d54419 into babel:main May 7, 2021
@sosukesuzuki sosukesuzuki deleted the fix-13280 branch May 7, 2021 20:38
@fisker
Copy link
Contributor

fisker commented May 8, 2021

Thanks for the quick fix.

This was referenced May 18, 2021
Closed
Closed
This was referenced May 26, 2021
Closed
Closed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: estree outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Import Attributes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: @babel/eslint-parser missing import assertion info in AST
5 participants
@sosukesuzuki @babel-bot @nicolo-ribaudo @fisker @JLHwung