Parse static blocks with typescript plugin #13243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sosukesuzuki
commented
May 1, 2021
•
sosukesuzuki
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #13234 |
| Patch: Bug Fix? | Y |
| Tests Added + Pass? | Yes |
| License | MIT |
sosukesuzuki
added
PR: Bug Fix 🐛
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a334b8f:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45805/ |
| @@ -0,0 +1,3 @@ | |||
| class Foo { | |||
| static private {} | |||
There was a problem hiding this comment.
We can report a better error, like Static class blocks cannot have any modifier
JLHwung
reviewed
May 3, 2021
| @@ -131,6 +131,8 @@ const TSErrors = makeErrorTemplates( | |||
| "A 'set' accessor cannot have rest parameter.", | |||
| SetAccesorCannotHaveReturnType: | |||
| "A 'set' accessor cannot have a return type annotation.", | |||
| StaticBlockCannotHaveanyModifier: | |||
There was a problem hiding this comment.
Suggested change
| StaticBlockCannotHaveanyModifier: | |
| StaticBlockCannotHaveModifier: |
nit-picking: I prefer shorter error codes.
JLHwung
reviewed
May 3, 2021
| @@ -0,0 +1,4 @@ | |||
| class Foo { | |||
| static foo; | |||
There was a problem hiding this comment.
As I read the name of the test, did you mean
Suggested change
| static foo; | |
| static static; |
?
JLHwung
approved these changes
May 3, 2021
JLHwung
reviewed
May 3, 2021
This comment has been minimized.
This comment has been minimized.
sosukesuzuki
force-pushed
the
static-blocks-with-typescript
branch
from
7cc5d28
to
a334b8f
Compare
nicolo-ribaudo
approved these changes
May 3, 2021
This was referenced May 18, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.