Support async do expressions #13116
Merged
Support async do expressions #13116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JLHwung
commented
Apr 7, 2021
•
JLHwung
commented
- Parse async do expressions (Parse async do expressions #13043)
- Transform async do expressions (Implement async-do-expressions transform #13117)
⚠️ Use the "Rebase and merge" button!
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45468/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e9e5cab:
|
nicolo-ribaudo
added
the
PR: Ready to be Merged
nicolo-ribaudo
force-pushed
the
feat-7.14.0/async-do-expressions
branch
from
9c923a8
to
4135692
Compare
* parse async do expressions * add test cases * update test fixtures * chore: add syntax-async-do-expressions * generater support * fix: do not transform async do expressions * chore: add asyncDoExpressions to missing plugin helpers * update ast types * add more test cases * throw when asyncDoExpressions is enabled but not doExpressions * avoid add parentheses for async do expressions * address review comments * chore: update parser typings
Co-authored-by: Brian Ng <bng412@gmail.com>
nicolo-ribaudo
force-pushed
the
feat-7.14.0/async-do-expressions
branch
from
4135692
to
e9e5cab
Compare
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.