New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix completion record for labeled statement #13084
Fix completion record for labeled statement #13084
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45437/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bf1e8fe:
|
Related - #13030. Tt conflicts, but it looks like it will be easy to fix the conflict since modified line would be https://github.com/babel/babel/pull/13030/files#diff-6828b1e955c2a5ac30a60be81472c92a36c5b90605ba94a4ebfcaedbbc41b43dR213
I think we only test it indirectly with |
@nicolo-ribaudo Ah, thanks :) This isn’t urgent for me, I think it would be fine to wait until the other PR is merged. |
Since we don't have any getCompletionRecords tests, we could also add the tests for do expressions as mentioned https://github.com/babel/babel/tree/main/packages/babel-plugin-proposal-do-expressions/test/fixtures/do-expressions as a substitute? // label.js
expect(do {
a: 1
}).toBe(1);
expect(do {
a: if (true) {
"bar";
}
}).toBe("bar"); |
@addaleax The other PR has been merged! |
2f089ee
to
67d5842
Compare
`{labelAlthoughIMeantItToBeAKey: value}` strikes again :)
67d5842
to
bf1e8fe
Compare
@nicolo-ribaudo Thank you, should be working now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
{labelAlthoughIMeantItToBeAKey: value}
strikes again :)