Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow Indexed Access Type support #13072

Closed
wants to merge 1 commit into from
Closed

Conversation

gkz
Copy link
Contributor

@gkz gkz commented Mar 30, 2021

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? x
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT

This adds parsing support for Flow's Indexed Access Type, e.g. type T = Obj['foo']. This feature is similar to the TypeScript feature of the same name.
Flow parser has parsed this feature since 0.146

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44876/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8001a36:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@sosukesuzuki
Copy link
Member

Oh, I've already implemented the same feature at #13053 ...

@gkz
Copy link
Contributor Author

gkz commented Mar 30, 2021

Oh, I've already implemented the same feature at #13053 ...

That's funny, we haven't publicized this feature anywhere yet, not even in the changelog, so it did not cross my mind someone external would have already added support in a non-merged PR.

@sosukesuzuki
Copy link
Member

I'm a also maintainer of Prettier so I saw that you created the PR to support this feature to Prettier.

@gkz
Copy link
Contributor Author

gkz commented Mar 30, 2021

It looks like the only differences in the PRs is that I have split the parser tests into separate sub-directories, otherwise pretty much identical. Since your PR is already accepted and tagged "Ready to be merged" I can close this one.

@gkz gkz closed this Mar 30, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants