Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: constant variables only enable constant react elements #13054

Merged
merged 1 commit into from Mar 25, 2021
Merged

fix: constant variables only enable constant react elements #13054

merged 1 commit into from Mar 25, 2021

Conversation

cgood92
Copy link
Contributor

@cgood92 cgood92 commented Mar 25, 2021

fix: constant variables only enable constant react elements

fix #13051

Q                       A
Fixed Issues? fix #13051
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

After submitting the issue 13051, @jridgewell suggested this fix. Thank you for your help @jridgewell.

@cgood92 cgood92 mentioned this pull request Mar 25, 2021
Closed
1 task
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44669/

JLHwung
JLHwung approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo added area: jsx i: regression PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Mar 25, 2021
nicolo-ribaudo
nicolo-ribaudo approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh we had tests for this and didn't notice it 😬

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit 266e077 into babel:main Mar 25, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: jsx i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@babel/plugin-transform-react-constant-elements@7.13.10 broken
4 participants
@cgood92 @babel-bot @JLHwung @nicolo-ribaudo