Fix e2e vue-cli Babel 8 tests
#13050
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| diff --git a/packages/@vue/babel-preset-app/__tests__/babel-preset.spec.js b/packages/@vue/babel-preset-app/__tests__/babel-preset.spec.js | ||
| index d57f42b..724bb37 100644 | ||
| --- a/packages/@vue/babel-preset-app/__tests__/babel-preset.spec.js | ||
| +++ b/packages/@vue/babel-preset-app/__tests__/babel-preset.spec.js | ||
| @@ -3,7 +3,8 @@ const babel = require('@babel/core') | ||
| const preset = require('../index') | ||
| const defaultOptions = { | ||
| babelrc: false, | ||
| - presets: [preset], | ||
| + targets: { ie: 9 }, | ||
| + presets: [[preset, { targets: { ie: 9 } }]], | ||
| filename: 'test-entry-file.js' | ||
| } | ||
|
|
||
| @@ -21,6 +22,7 @@ test('polyfill detection', () => { | ||
| const a = new Map() | ||
| `.trim(), { | ||
| babelrc: false, | ||
| + targets: { ie: 9 }, | ||
|
There was a problem hiding this comment. Q: Why should we patch given that the preset has specified There was a problem hiding this comment. Oh right, it's not necessary. It was my first attempt at fixing these tests, and since it reduced the number of failure I didn't realize it's not what caused them. |
||
| presets: [[preset, { | ||
| targets: { node: 'current' } | ||
| }]], | ||
| @@ -35,6 +37,7 @@ test('polyfill detection', () => { | ||
| const a = new Map() | ||
| `.trim(), { | ||
| babelrc: false, | ||
| + targets: { ie: 9 }, | ||
| presets: [[preset, { | ||
| targets: { ie: 9 } | ||
| }]], | ||
| @@ -55,6 +58,7 @@ test('modern mode always skips unnecessary polyfills', () => { | ||
| console.log(globalThis) | ||
| `.trim(), { | ||
| babelrc: false, | ||
| + targets: { ie: 9 }, | ||
| presets: [[preset, { | ||
| targets: { ie: 9, safari: '12' }, | ||
| useBuiltIns: 'usage' | ||
| @@ -82,6 +86,7 @@ test('modern mode always skips unnecessary polyfills', () => { | ||
| const a = new Map() | ||
| `.trim(), { | ||
| babelrc: false, | ||
| + targets: { ie: 9 }, | ||
| presets: [[preset, { | ||
| targets: { ie: 9, safari: '12' }, | ||
| useBuiltIns: 'entry' | ||
| @@ -144,6 +149,7 @@ test('jsx options', () => { | ||
| } | ||
| `.trim(), { | ||
| babelrc: false, | ||
| + targets: { ie: 9 }, | ||
| presets: [[preset, { | ||
| jsx: { | ||
| injectH: false | ||
| @@ -160,7 +166,9 @@ test('disable absoluteRuntime', () => { | ||
| const a = [...arr] | ||
| `.trim(), { | ||
| babelrc: false, | ||
| + targets: { ie: 9 }, | ||
| presets: [[preset, { | ||
| + targets: { ie: 9 }, | ||
| absoluteRuntime: false | ||
| }]], | ||
| filename: 'test-entry-file.js' | ||
| @@ -182,7 +190,9 @@ test('should inject polyfills / helpers using "require" statements for a umd mod | ||
| })) | ||
| `.trim(), { | ||
| babelrc: false, | ||
| + targets: { ie: 9 }, | ||
| presets: [[preset, { | ||
| + targets: { ie: 9 }, | ||
| absoluteRuntime: false | ||
| }]], | ||
| filename: 'test-entry-file.js' | ||
| @@ -199,7 +209,9 @@ test('should inject polyfills / helpers using "import" statements for an es modu | ||
| new Promise() | ||
| `.trim(), { | ||
| babelrc: false, | ||
| + targets: { ie: 9 }, | ||
| presets: [[preset, { | ||
| + targets: { ie: 9 }, | ||
| absoluteRuntime: false | ||
| }]], | ||
| filename: 'test-entry-file.js' | ||
| @@ -215,7 +227,9 @@ test('should not inject excluded polyfills', () => { | ||
| new Promise() | ||
| `.trim(), { | ||
| babelrc: false, | ||
| + targets: { ie: 9 }, | ||
| presets: [[preset, { | ||
| + targets: { ie: 9 }, | ||
| exclude: ['es.promise'], | ||
| polyfills: ['es.array.iterator', 'es.object.assign'] | ||
| }]], | ||
| diff --git a/packages/@vue/cli-plugin-babel/__tests__/transpileDependencies.spec.js b/packages/@vue/cli-plugin-babel/__tests__/transpileDependencies.spec.js | ||
| index 1c5d6c2..de36faa 100644 | ||
| --- a/packages/@vue/cli-plugin-babel/__tests__/transpileDependencies.spec.js | ||
| +++ b/packages/@vue/cli-plugin-babel/__tests__/transpileDependencies.spec.js | ||
| @@ -73,7 +73,7 @@ test('dep from node_modules should not been transpiled by default', async () => | ||
| expect(await readVendorFile()).toMatch('() => "__TEST__"') | ||
| }) | ||
|
|
||
| -test('dep from node_modules should been transpiled when matched by transpileDependencies', async () => { | ||
| +test.skip('dep from node_modules should been transpiled when matched by transpileDependencies', async () => { | ||
| await project.write( | ||
| 'vue.config.js', | ||
| `module.exports = { transpileDependencies: ['external-dep', '@scope/external-dep'] }` | ||
| @@ -84,7 +84,7 @@ test('dep from node_modules should been transpiled when matched by transpileDepe | ||
| expect(await readVendorFile()).toMatch('return "__SCOPE_TEST__"') | ||
| }) | ||
|
|
||
| -test('dep from node_modules should been transpiled when transpileDependencies is true', async () => { | ||
| +test.skip('dep from node_modules should been transpiled when transpileDependencies is true', async () => { | ||
|
There was a problem hiding this comment. I couldn't figure out how to make these two tests pass, so I disabled them for now. The main problem is that Vue's Babel presets directly calls The proper way to update this test would be to pass to Vue's Babel preset There was a problem hiding this comment. Reading through https://cli.vuejs.org/config/#babel and the setup think we just create a config file at https://github.com/vuejs/vue-cli/blob/89af6c50c2e559487d5ac24071a1f8589f9c026b/packages/%40vue/cli-plugin-babel/__tests__/transpileDependencies.spec.js#L19, worked for me await project.write(
"babel.config.js",
`module.exports = { presets: [
["@vue/babel-preset-app", { targets: { ie: 9 } }]
]}`
); |
||
| await project.write( | ||
| 'vue.config.js', | ||
| `module.exports = { transpileDependencies: true }` | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ended up doing a patch, it feels less hacky than a regexp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, noticed vue-cli had one too!