Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e vue-cli Babel 8 tests #13050

Merged
merged 7 commits into from
Mar 25, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions scripts/integration-tests/e2e-vue-cli.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ node "$PWD"/../../utils/bump-babel-dependencies.js
yarn lerna exec -- node "$PWD"/../../utils/bump-babel-dependencies.js
yarn install

if [ "$BABEL_8_BREAKING" = true ] ; then
# Babel 8 defaults to "default, not ie 11", but this breaks vue-cli's tests
# which expect different ES features to be compiled.
patch -p1 < "$PWD"/../../patches/vue-cli-babel-8.patch
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ended up doing a patch, it feels less hacky than a regexp.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, noticed vue-cli had one too!

fi

# Test
CI=true yarn test -p babel,babel-preset-app

Expand Down
79 changes: 79 additions & 0 deletions scripts/integration-tests/patches/vue-cli-babel-8.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
diff --git a/packages/@vue/babel-preset-app/__tests__/babel-preset.spec.js b/packages/@vue/babel-preset-app/__tests__/babel-preset.spec.js
index d57f42b..60c938a 100644
--- a/packages/@vue/babel-preset-app/__tests__/babel-preset.spec.js
+++ b/packages/@vue/babel-preset-app/__tests__/babel-preset.spec.js
@@ -3,7 +3,7 @@ const babel = require('@babel/core')
const preset = require('../index')
const defaultOptions = {
babelrc: false,
- presets: [preset],
+ presets: [[preset, { targets: { ie: 9 } }]],
filename: 'test-entry-file.js'
}

@@ -161,6 +161,7 @@ test('disable absoluteRuntime', () => {
`.trim(), {
babelrc: false,
presets: [[preset, {
+ targets: { ie: 9 },
absoluteRuntime: false
}]],
filename: 'test-entry-file.js'
@@ -183,6 +184,7 @@ test('should inject polyfills / helpers using "require" statements for a umd mod
`.trim(), {
babelrc: false,
presets: [[preset, {
+ targets: { ie: 9 },
absoluteRuntime: false
}]],
filename: 'test-entry-file.js'
@@ -200,6 +202,7 @@ test('should inject polyfills / helpers using "import" statements for an es modu
`.trim(), {
babelrc: false,
presets: [[preset, {
+ targets: { ie: 9 },
absoluteRuntime: false
}]],
filename: 'test-entry-file.js'
@@ -216,6 +219,7 @@ test('should not inject excluded polyfills', () => {
`.trim(), {
babelrc: false,
presets: [[preset, {
+ targets: { ie: 9 },
exclude: ['es.promise'],
polyfills: ['es.array.iterator', 'es.object.assign']
}]],
diff --git a/packages/@vue/cli-plugin-babel/__tests__/transpileDependencies.spec.js b/packages/@vue/cli-plugin-babel/__tests__/transpileDependencies.spec.js
index 1c5d6c2..6f90582 100644
--- a/packages/@vue/cli-plugin-babel/__tests__/transpileDependencies.spec.js
+++ b/packages/@vue/cli-plugin-babel/__tests__/transpileDependencies.spec.js
@@ -78,6 +78,14 @@ test('dep from node_modules should been transpiled when matched by transpileDepe
'vue.config.js',
`module.exports = { transpileDependencies: ['external-dep', '@scope/external-dep'] }`
)
+ await project.write(
+ 'babel.config.js',
+ `module.exports = {
+ presets: [
+ ["@vue/babel-preset-app", { targets: { ie: 9 } }]
+ ]
+ }`
+ )
await project.run('vue-cli-service build')
expect(await readVendorFile()).toMatch('return "__TEST__"')

@@ -89,6 +97,14 @@ test('dep from node_modules should been transpiled when transpileDependencies is
'vue.config.js',
`module.exports = { transpileDependencies: true }`
)
+ await project.write(
+ 'babel.config.js',
+ `module.exports = {
+ presets: [
+ ["@vue/babel-preset-app", { targets: { ie: 9 } }]
+ ]
+ }`
+ )
await project.run('vue-cli-service build')
expect(await readVendorFile()).toMatch('return "__TEST__"')