New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce parser error codes #13033
Merged
nicolo-ribaudo
merged 12 commits into
babel:feat-7.14.0/parser-updates
from
sosukesuzuki:introduce-error-code
Apr 3, 2021
Merged
Introduce parser error codes #13033
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
43187c0
Introduce error code
sosukesuzuki 3c798b1
Define new error template
sosukesuzuki 9da92f3
Use ErrorTemplates type
sosukesuzuki b1f3a79
Use makeErrorTemplate to reduce boilerplate
sosukesuzuki 0922ecf
Remove sourcetype related errors
sosukesuzuki ebfce73
Remove unnecessary type annotation
sosukesuzuki f914226
Fix unexpected signature
sosukesuzuki 363ca85
Introduce reasonCode
sosukesuzuki a7b4bc3
Add missing error code
sosukesuzuki a0ef883
Add ErrorCodes objects
sosukesuzuki 23e0bf1
Fix conflicts
sosukesuzuki f07223d
Add tests for error codes
sosukesuzuki File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
// @flow | ||
|
||
export const ErrorCodes = Object.freeze({ | ||
SyntaxError: "BABEL_PARSER_SYNTAX_ERROR", | ||
SourceTypeModuleError: "BABEL_PARSER_SOURCETYPE_MODULE_REQUIRED", | ||
}); | ||
|
||
export type ErrorCode = $Values<typeof ErrorCodes>; |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be good to add
params
as a property.Use case: in Prettier,
Unexpected reserved word 'yield'
should be suppressed,Unexpected reserved word 'for'
should be rethrown. prettier/prettier#10603There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to split the error between
UnexpectedKeyword
andUnexpectedContextualKeyword
if that works too, and avoid exposing too much internal details about how we build errors.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's a better solution for that use case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thorn0 I was going to implement this, but I noticed that we already have two different errors:
UnexpectedKeyword
for things likefor
,if
,while
, ...UnexpectedReservedWord
for things likeyield
,await
,enum
, ...