Correctly handle relative browserslistConfigFile paths
#13031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44739/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 921fcac:
|
nicolo-ribaudo
force-pushed
the
browserslistrc-config-relative
branch
from
bab0575
to
4e9d92c
Compare
JLHwung
approved these changes
Mar 22, 2021
There was a problem hiding this comment.
Can you also update https://babeljs.io/docs/en/options#browserslistconfigfile?
nicolo-ribaudo
force-pushed
the
browserslistrc-config-relative
branch
from
4e9d92c
to
921fcac
Compare
existentialism
approved these changes
Mar 26, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is from #13028, please review that PR first.
The current behavior of
browserslistConfigFileis to be always resolved relative to the project root, regardless of where it's set. This PR changes it to be resolved:cwd, if it's specified in programmatic optionsThis aligns it behavior with every other Babel option whose value can be a relative path (
extends,plugins,presets), and (when used as a progrmmatic option) with how Node.js generally handles relative paths (they are always resolved relative to the cwd).This change is technically observable, but probably no one ever reported it as a bug because in 99% of the cases
root===cwd===config file location.