Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lodash/has #13023

Merged
merged 2 commits into from Mar 19, 2021
Merged

Remove lodash/has #13023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fae47b
Remove lodash/has
jridgewell Mar 19, 2021
bf42813
Update lockfile
jridgewell Mar 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/third-party-libs.js.flow
View file
Open in desktop
Expand Up @@ -22,10 +22,6 @@ declare module "json5" {
};
}

declare module "lodash/defaults" {
declare export default <T: Object>(T, Object) => T;
}

declare module "lodash/clone" {
declare export default <T>(obj: T) => T;
}
Expand Down
3 changes: 1 addition & 2 deletions packages/babel-helper-define-map/package.json
View file
Open in desktop
Expand Up @@ -15,7 +15,6 @@
"main": "lib/index.js",
"dependencies": {
"@babel/helper-function-name": "workspace:^7.12.13",
"@babel/types": "workspace:^7.12.13",
"lodash": "^4.17.19"
"@babel/types": "workspace:^7.12.13"
}
}
3 changes: 2 additions & 1 deletion packages/babel-helper-define-map/src/index.js
View file
Open in desktop
@@ -1,5 +1,4 @@
import nameFunction from "@babel/helper-function-name";
import has from "lodash/has";
import * as t from "@babel/types";

function toKind(node: Object) {
Expand All @@ -12,6 +11,8 @@ function toKind(node: Object) {
return "value";
}

const has = Function.prototype.call.bind(Object.prototype.hasOwnProperty);

export function push(
mutatorMap: Object,
node: Object,
Expand Down
1 change: 0 additions & 1 deletion yarn.lock
View file
Open in desktop
Expand Up @@ -490,7 +490,6 @@ __metadata:
dependencies:
"@babel/helper-function-name": "workspace:^7.12.13"
"@babel/types": "workspace:^7.12.13"
lodash: ^4.17.19
languageName: unknown
linkType: soft

Expand Down