Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lodash sortBy use #13021

Merged
merged 6 commits into from Mar 25, 2021
Merged

Remove lodash sortBy use #13021

merged 6 commits into from Mar 25, 2021

Commits on Mar 18, 2021

  1. Remove lodash sortBy use 

    This one `require` increases startup time by 100ms (coming from `loadOptions`).
    @jridgewell
    jridgewell committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    42fd9bf View commit details
    Browse the repository at this point in the history

  2. My kingdom for a stable sort!

    @jridgewell
    jridgewell committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    0f4dc6a View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2021

  1. Create new array instance, and ensure we sort the full array

    @jridgewell
    jridgewell committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    a4d25aa View commit details
    Browse the repository at this point in the history

  2. Only sort when needed

    @jridgewell
    jridgewell committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    87f8cfb View commit details
    Browse the repository at this point in the history

  3. Apparently logical assignment or nullish coalescing isn't enabled

    @jridgewell
    jridgewell committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    30d544c View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2021

  1. Use object to bucket

    @jridgewell
    jridgewell committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    23da89c View commit details
    Browse the repository at this point in the history