Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importing polyfill plugins in the Rollup bundle #13017

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Mar 18, 2021

Q                       A
Fixed Issues? Fixes #13016
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

The polyfill plugins are ESM files compiled down to CJS, and thus they have an __esModule: true property.

When bundling CJS files that have the __esModule: true option, Rollup matches the default Babel interop and transforms import foo from "foo" to const foo = require("foo").default (rather than const foo = require("foo"), as Node.js does).

This PR introduces a small Babel plugins that rewrites those specific import foo to import * as foo when bundling.

I opened rollup/plugins#838 to see if the Rollup community is interested in aligning with Node.js.

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44374/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit df07f0a:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo merged commit 4beca39 into babel:main Mar 22, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the fix-rollup-import-of-polyfill-plugins branch March 22, 2021 13:48
@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Mar 22, 2021

Merging since this is just a change in the build config and not in the source itself.

I'll revert once rollup/plugins#838 is merged.

@nicolo-ribaudo nicolo-ribaudo added this to In progress in Move to native ES modules via automation Apr 1, 2021
@nicolo-ribaudo nicolo-ribaudo moved this from In progress to Done in Move to native ES modules Apr 1, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: standalone PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Development

Successfully merging this pull request may close these issues.

@babel/standalone is broken after #12795
3 participants