allowMutablePropsOnTags: cache JSX constant elements with function props
#12975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Output optimization 🔬
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4f9b9c4:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51305/ |
jridgewell
approved these changes
Mar 7, 2021
| // If we allow mutable props, tags with function expressions can be | ||
| // safely hoisted. | ||
| const { mutablePropsAllowed } = state; | ||
| if (mutablePropsAllowed && path.isFunction()) return skip(); |
There was a problem hiding this comment.
I'd propose we traverse with the targetScopeVisitor here, so we could keep the two traversals together.
nicolo-ribaudo
force-pushed
the
constant-elements-hoist-functions
branch
from
4f9b9c4
to
425f9f7
Compare
nicolo-ribaudo
commented
Feb 16, 2022
| if (path.isIdentifier()) { | ||
| const binding = path.scope.getBinding(path.node.name); | ||
| if (binding && binding.constant) return; | ||
| } | ||
|
|
||
| if (!path.isImmutable()) { | ||
| // If it's not immutable, it may still be a pure expression, such as string concatenation. |
There was a problem hiding this comment.
This was not actually changed; I suggest hiding whitespace changes when reviewing.
existentialism
approved these changes
Feb 21, 2022
nicolo-ribaudo
changed the title
allowMutablePropsOnTags allowMutablePropsOnTags: cache JSX const elements w/ fn props
nicolo-ribaudo
changed the title
allowMutablePropsOnTags: cache JSX const elements w/ fn propsallowMutablePropsOnTags: cache JSX constant elements with function props
1 task
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jridgewell You were right!
I had to split
immutabiltyVisitorandtargetScopeVisitorin two visitors because I had to skip functions when checking for immutability, but traverse them when collecting references.