New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not bail on SHOW_CONFIG_FOR matches #12954
Changes from all commits
2ef3acf
74acc83
bad56f7
51b1c22
44f8fb0
46b622e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
"use strict"; | ||
"use strict"; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,3 +29,4 @@ programmatic options from @babel/cli | |
}, | ||
"filename": "src//foo.js" | ||
} | ||
-----End Babel configs----- |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
"use strict"; | ||
"use strict"; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,3 +29,4 @@ programmatic options from @babel/cli | |
}, | ||
"filename": "src/foo.js" | ||
} | ||
-----End Babel configs----- |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
"use strict"; |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,7 +39,6 @@ config <CWD>/my-extended.js .overrides[0].env["test"] | |
"@foo/babel-preset-1", | ||
[ | ||
{ | ||
"name": "@foo/inline-babel-preset-1", | ||
"plugins": [ | ||
{ | ||
"name": "@foo/inline-babel-plugin-1", | ||
|
@@ -125,3 +124,5 @@ programmatic options from @babel/cli | |
}, | ||
"filename": "./src/index.js" | ||
} | ||
-----End Babel configs----- | ||
"use strict"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we should print a separator between the code and the config? Something like
As an alternative, maybe it would be better to print the config on stderr so that it doesn't breaks things such as
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think the debug output should be directed to For example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: What is this change needed for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Babel will throw
name
is not a valid option. I didn't knowname
is forbidden onpreset
until now. 🤦♂️