Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nullish extends in interfaceish #12920

Merged
merged 2 commits into from Mar 1, 2021
Merged

Allow nullish extends in interfaceish #12920

merged 2 commits into from Mar 1, 2021

Commits on Feb 28, 2021

  1. Allow nullish extends in interfaceish 

    Otherwise code such as

```ts
t.interfaceDeclaration(
  t.identifier('id'),
  undefined,
  undefined,
  t.objectTypeAnnotation([])
)
```

Will fail when priting with ` TypeError: unknown: Cannot read property 'length' of null`
Despite nullish values being allowed in `t.interfaceDeclaration` definitions
    @saitonakamura
    saitonakamura committed Feb 28, 2021
    Copy the full SHA
    4373398 View commit details
    Browse the repository at this point in the history

  2. Update packages/babel-generator/src/generators/flow.ts 

    Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
    @saitonakamura @nicolo-ribaudo
    saitonakamura and nicolo-ribaudo committed Feb 28, 2021
    Copy the full SHA
    2676750 View commit details
    Browse the repository at this point in the history