New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use useESModules
in @babel/runtime
build script
#12842
Merged
nicolo-ribaudo
merged 1 commit into
babel:main
from
nicolo-ribaudo:dont-use-useESModules-internal
Feb 22, 2021
Merged
Don't use useESModules
in @babel/runtime
build script
#12842
nicolo-ribaudo
merged 1 commit into
babel:main
from
nicolo-ribaudo:dont-use-useESModules-internal
Feb 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
the
PR: Internal 🏠
A type of pull request used for our changelog categories
label
Feb 21, 2021
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7da4648:
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/41644/ |
JLHwung
approved these changes
Feb 22, 2021
existentialism
approved these changes
Feb 22, 2021
This was referenced Mar 6, 2021
Merged
This was referenced Mar 13, 2021
Closed
Merged
This was referenced Mar 15, 2021
Merged
Merged
github-actions
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
May 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
PR: Internal 🏠
A type of pull request used for our changelog categories
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make bootstrap
We are using
@babel/plugin-transform-runtime
from the monorepo itself to build@babel/runtime
, so after #12632useESModules
is not needed anymore.This doesn't change the committed helpers (https://github.com/babel/babel/tree/main/packages/babel-runtime/helpers), as expected.