Register binding when transforming TSParameterProperty #12796
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the issue #11061 is triggered from
babel/packages/babel-helper-module-transforms/src/rewrite-live-references.js
Lines 180 to 187 in c22e72e
where both the local binding and root binding of
message
isundefined
and therefore replaced byfirebaseAdmin.messging
, it should be fixed intransform-typescript
when we transformTSParameterProperty
to general function parameters.I don't think the root binding of
message
should beundefined
, too. But I prefer to fix that in another PR.