Reuse the readOnlyError
helper for private methods
#12792
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #12707, I noticed that
classPrivateMethodSet
is basically the same asreadOnlyError
except that it doesn't say exactly what cannot be reassigned.The
readOnlyError
helper will throw something like"#foo" is read-only"
, which is also more correct when reassigning a private getter (since it's not technically a method). Also, we avoid injecting two different helpers in the generated bundle.This PR also removes
classPrivateMethodSet
for Babel 8.