New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support destructuring variable declarator within TS namespace #12760
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
53b5964
refactor: extract handleVariableDeclaration
JLHwung d724f23
fix: support general variable declarator under namespace
JLHwung 7ba4725
fix: support general declarator on export module id duplication check
JLHwung 0079773
refactor: use for-in
JLHwung File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
...abel-plugin-transform-typescript/test/fixtures/namespace/namespace-nested-module/input.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
namespace N { | ||
const M1 = {} | ||
export module M1 {} | ||
const { M2 } = {} | ||
export module M2 {} | ||
} |
13 changes: 13 additions & 0 deletions
13
...el-plugin-transform-typescript/test/fixtures/namespace/namespace-nested-module/output.mjs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
let N; | ||
|
||
(function (_N) { | ||
const M1 = {}; | ||
|
||
(function (_M) {})(M1 || (M1 = _N.M1 || (_N.M1 = {}))); | ||
|
||
const { | ||
M2 | ||
} = {}; | ||
|
||
(function (_M2) {})(M2 || (M2 = _N.M2 || (_N.M2 = {}))); | ||
})(N || (N = {})); |
6 changes: 6 additions & 0 deletions
6
...s/babel-plugin-transform-typescript/test/fixtures/namespace/nested-destructuring/input.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
class C { } | ||
namespace N { | ||
export const { a } = C; | ||
export const [ b ] = C; | ||
export const [ { a: [{ b: c }] }] = A, { a: { b: { d = 1 } } = {}, ...e } = C; | ||
} |
24 changes: 24 additions & 0 deletions
24
...babel-plugin-transform-typescript/test/fixtures/namespace/nested-destructuring/output.mjs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
class C {} | ||
|
||
let N; | ||
|
||
(function (_N) { | ||
const { | ||
a | ||
} = C; | ||
_N.a = a; | ||
const [{ | ||
a: [{ | ||
b: c | ||
}] | ||
}] = A, | ||
{ | ||
a: { | ||
b: { | ||
d = 1 | ||
} | ||
} = {}, | ||
...e | ||
} = C; | ||
_N.e = e, _N.c = c, _N.d = d; | ||
})(N || (N = {})); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Babel currently throws for
because
M2
is never added tonames
, andTSModuleDeclaration
handler will addM2
variable declarations which collide withconst { M2 } = {}
.