Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform labeled for-of inside braceless if statement #12611

Merged
merged 1 commit into from Jan 12, 2021

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jan 12, 2021

Q                       A
Fixed Issues? Fixes #12610
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Jan 12, 2021
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/37297/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9aaa96c:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@existentialism existentialism merged commit 58d2f41 into babel:main Jan 12, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the issue-12610 branch January 12, 2021 19:17
@NagRock
Copy link

NagRock commented Jan 12, 2021

@existentialism 👍 that was really fast! Thanks.

Any info when it will be released on npm repository?

@nicolo-ribaudo
Copy link
Member Author

We'll have a minor release before the end of January, but we might release a patch sooner.

@NagRock
Copy link

NagRock commented Jan 13, 2021

Thanks for the info. It would be awesome if patch release will be sooner. It is a blocker for using https://github.com/codemirror/lint in Angular project.

@NagRock
Copy link

NagRock commented Feb 2, 2021

We still cannot build angular application because of this bug.
@nicolo-ribaudo any update about release?

@nicolo-ribaudo
Copy link
Member Author

Released as 7.12.13

@NagRock
Copy link

NagRock commented Feb 3, 2021

@nicolo-ribaudo :yay: !!!

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labeled for/of loop as brace-less sub-statement crashes
5 participants