Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disappearing polyfills when conflicting versions of preset are used #12554

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+25 −6
Open

Fix disappearing polyfills when conflicting versions of preset are used #12554

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e31804
Fix disappearing core-js polyfills when conflicting versions of prese…
ertrzyiks Dec 23, 2020
ee5d917
Update output of fixtures using direct imports
ertrzyiks Dec 23, 2020
28f6547
Add test case using imports with extensions
ertrzyiks Jan 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/babel-preset-env/src/polyfills/corejs3/entry-plugin.js
View file
Open in desktop
Expand Up @@ -56,7 +56,8 @@ export default function (
modules.length === 1 &&
polyfills.has(modules[0]) &&
available.has(modules[0]) &&
getModulePath(modules[0]) === source
(getModulePath(modules[0]) === source ||
getModulePath(modules[0]) === `${source}.js`)
) {
return false;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/babel-preset-env/test/fixtures/corejs3/entry-entries-modules-chrome-71/output.mjs
View file
Open in desktop
@@ -1,2 +1,2 @@
import "core-js/modules/es.object.from-entries.js";
import "core-js/modules/esnext.string.replace-all.js";
import 'core-js/modules/es.object.from-entries';
import 'core-js/modules/esnext.string.replace-all';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add test cases when input file contains core-js imports ending with .js?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍 is this single scenario enough or you had more cases in mind?
28f6547

6 changes: 3 additions & 3 deletions packages/babel-preset-env/test/fixtures/corejs3/entry-entries-modules/output.mjs
View file
Open in desktop
@@ -1,3 +1,3 @@
import "core-js/modules/es.symbol.js";
import "core-js/modules/es.object.from-entries.js";
import "core-js/modules/esnext.string.replace-all.js";
import 'core-js/modules/es.symbol';
import 'core-js/modules/es.object.from-entries';
import 'core-js/modules/esnext.string.replace-all';